1046222 - Make XPCOM_DEBUG_BREAK default to "warn" on Windows

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Right now, it defaults to "trap", which when run under the debugger, causes a breakpoint.  We still have many assertions, and this is just an unnecessary annoyance when debugging on windows.  Developers need to know to edit the visual studio project environment variables to set XPCOM_DEBUG_BREAK=warn in order to debug.

On other platforms, it defaults to "warn".  Let's do the same on windows?  Specifically, this code in nsDebugImpl.cpp:


#if defined(XP_WIN) && defined(MOZ_METRO)
  if (IsRunningInWindowsMetro()) {
    gAssertBehavior = NS_ASSERT_WARN;
  } else {
    gAssertBehavior = NS_ASSERT_TRAP;
  }
#elif defined(XP_WIN)
  gAssertBehavior = NS_ASSERT_TRAP;
#else
  gAssertBehavior = NS_ASSERT_WARN;
#endif

needs to just be gAssertBehavior = NS_ASSERT_WARN.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: default to "warn" on Windows

Default to "warn" behaviour on Windows to avoid development papercut.

Comment 2

[Benjamin Smedberg]

Comment on attachment 8464783 [details] [diff] [review]
default to "warn" on Windows

Please announce to dev.platform.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/0f471ba800e1

posted to dev.platform as well.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f471ba800e1