Closed Bug 1046248 Opened 10 years ago Closed 10 years ago

[Messages] Set explicit background image size for "Add attachment" button

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S1 (1aug)

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

(Whiteboard: [sms-sprint-2.1S1])

Attachments

(1 file)

GitHub pull request URL
46 bytes, text/x-github-pull-request
steveck
: review+
Details | Review 
*** Follow-up for bug 1026694 ***

In patch for bug 1026694 background image size wasn't set explicitly that leads to bigger-than-expected icon on HD screens.
Hey Steve, could you please review this tiny change that I missed in the patch for bug 1026694.

Thanks!
Attachment #8464851 - Flags: review?(schung)
Whiteboard: [sms-sprint-2.0S6]
Target Milestone: --- → 2.1 S1 (1aug)
Comment on attachment 8464851 [details] [review]
GitHub pull request URL

My bad :( I should test it with hdpi flag set. Thanks for the revisiting!
Attachment #8464851 - Flags: review?(schung) → review+
Thanks!

Master: https://github.com/mozilla-b2g/gaia/commit/6548f8a89654727eb3a65200ef14298e106eb099
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [sms-sprint-2.0S6] → [sms-sprint-2.1S1]
You need to log in before you can comment on or make changes to this bug.