Vertical margin on small viewports is off on “webmaker” template for landing pages

RESOLVED FIXED

Status

Webmaker
webmaker.org
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: akirose, Assigned: Katie Thomas, Mentored)

Tracking

Details

(Whiteboard: [landingpages] [techdebt] [goodfirstbug], URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 8464849 [details]
2014-07-29-Stand up for Net Neutrality-568x2460.png

Comment 1

4 years ago
I'd like to take it and try to fix the bug. Let me know briefly what is that i have to do. I'm still a beginner and would appreciate if you'd give me a lead on how to solve this bug. 

Thank you.
(Reporter)

Comment 2

4 years ago
Created attachment 8470958 [details]
9bidz.png

Does this clarify what this page needs?
Attachment #8464849 - Attachment is obsolete: true
(Reporter)

Updated

4 years ago
Flags: needinfo?(akshaytiwari.003)
(Assignee)

Comment 3

4 years ago
This seems like a great first bug for me!  Let me know if I can help.
(Reporter)

Comment 4

4 years ago
All yours! Let me know if you need any help or if the README is missing any info. FYI, I'm on vacation Monday and Tuesday.
Assignee: nobody → katiemthom
Flags: needinfo?(akshaytiwari.003)
(Assignee)

Comment 5

4 years ago
Awesome, thanks!
(Assignee)

Comment 6

4 years ago
Hey Aki,

I'm having trouble locating the relevant file in webmaker-suite.  I found the relevant url: https://welcome.webmaker.org/from/net-neutrality/. I ran a node update-webmaker and acked for "webmaker-landing" which I found in the HTML of that url, but no luck. How would you suggest I track down the files I need?

(I'm actually heading out on vacation tomorrow--will be back on Tuesday!)

Katie
(Reporter)

Comment 7

4 years ago
Hey Katie

This repo actually isn't part of webmaker-suite (yet?), it has to be cloned directly from https://github.com/mozilla/webmaker-landing-pages
(Assignee)

Comment 8

4 years ago
That explains it!  Thank you. Is there a place that I could have found that information?
(Reporter)

Comment 9

4 years ago
Agh. No. I'm so sorry! I usually pride myself on having great documentation! I'll look into having landing pages added as their own product in Bugzilla for clarity. Lmk if you have any questions with the README, and be sure to pull from upstream, update your env, npm install—we made some big commits after you left your comment last night.
(Assignee)

Comment 10

4 years ago
That would be awesome.  Thanks for the advice--I'm excited to get going with this when I'm back in SF next week!
(Reporter)

Updated

4 years ago
Attachment #8481803 - Flags: feedback?(aki) → feedback+

Comment 12

4 years ago
Commit pushed to master at https://github.com/mozilla/webmaker-landing-pages

https://github.com/mozilla/webmaker-landing-pages/commit/1c427b53d45d52138439f7851949210cfe895007
Merge pull request #72 from katiemthom/bug1046257

Fixes Bug 1046257 - Vertical margin on small viewports is off on “webmaker” template for landing pages
(Reporter)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 13

4 years ago
It looks like this fix hasn't made it to production yet.  Is there anything I need to do for that?
You need to log in before you can comment on or make changes to this bug.