1046257 - Vertical margin on small viewports is off on “webmaker” template for landing pages

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Aki Rose Braun [:akirose]]

Attachment: 2014-07-29-Stand up for Net Neutrality-568x2460.png

Comment 1

[akshaytiwari.003]

I'd like to take it and try to fix the bug. Let me know briefly what is that i have to do. I'm still a beginner and would appreciate if you'd give me a lead on how to solve this bug. 

Thank you.

Comment 2

[Aki Rose Braun [:akirose]]

Attachment: 9bidz.png

Does this clarify what this page needs?

Comment 3

[Katie Thomas]

This seems like a great first bug for me!  Let me know if I can help.

Comment 4

[Aki Rose Braun [:akirose]]

All yours! Let me know if you need any help or if the README is missing any info. FYI, I'm on vacation Monday and Tuesday.

Comment 5

[Katie Thomas]

Awesome, thanks!

Comment 6

[Katie Thomas]

Hey Aki,

I'm having trouble locating the relevant file in webmaker-suite.  I found the relevant url: https://welcome.webmaker.org/from/net-neutrality/. I ran a node update-webmaker and acked for "webmaker-landing" which I found in the HTML of that url, but no luck. How would you suggest I track down the files I need?

(I'm actually heading out on vacation tomorrow--will be back on Tuesday!)

Katie

Comment 7

[Aki Rose Braun [:akirose]]

Hey Katie

This repo actually isn't part of webmaker-suite (yet?), it has to be cloned directly from https://github.com/mozilla/webmaker-landing-pages

Comment 8

[Katie Thomas]

That explains it!  Thank you. Is there a place that I could have found that information?

Comment 9

[Aki Rose Braun [:akirose]]

Agh. No. I'm so sorry! I usually pride myself on having great documentation! I'll look into having landing pages added as their own product in Bugzilla for clarity. Lmk if you have any questions with the README, and be sure to pull from upstream, update your env, npm install—we made some big commits after you left your comment last night.

Comment 10

[Katie Thomas]

That would be awesome.  Thanks for the advice--I'm excited to get going with this when I'm back in SF next week!

Comment 11

[Katie Thomas]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/72

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-landing-pages

https://github.com/mozilla/webmaker-landing-pages/commit/1c427b53d45d52138439f7851949210cfe895007
Merge pull request #72 from katiemthom/bug1046257

Fixes Bug 1046257 - Vertical margin on small viewports is off on “webmaker” template for landing pages

Comment 13

[Katie Thomas]

It looks like this fix hasn't made it to production yet.  Is there anything I need to do for that?

Comment 14

[Aki Rose Braun [:akirose]]

My bad, I didn't deploy. Done now. https://travis-ci.org/mozilla/webmaker-landing-pages/builds/35303844