Closed Bug 1046316 Opened 10 years ago Closed 10 years ago

[Camera] Focus view not appended to viewfinder

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 unaffected, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S1 (1aug)
Tracking Flags:
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- fixed

People

(Reporter: dmarcos, Assigned: dmarcos, NeedInfo)

References

Details

(Whiteboard: [caf priority: p2][CR 696647])

Attachments

(1 file)

Pull Request
46 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
The faces view is appended twice and the focus view is never appended. Regression introduced by bug 1038172
Assignee: nobody → dmarcos
Attached file Pull Request — 

    
  

        Attachment #8464955 -
        Flags: review?(jdarcangelo)

    
    

    
  
Comment on attachment 8464955 [details] [review]
Pull Request

LGTM!

        Attachment #8464955 -
        Flags: review?(jdarcangelo) → review+

    
    

    
  
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/bb69e716f67edc0b672f0ef88839de1c5c9fe86c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
[Blocking Requested - why for this release]:
Blocks: CAF-v2.0-FC-metabug
blocking-b2g: --- → 2.0?
Whiteboard: [CR 696647]
Whiteboard: [CR 696647] → [caf priority: p2][CR 696647]
blocking-b2g: 2.0? → 2.0+

    
    

    
  
Needs rebasing for v2.0 uplift (or depends on other patches that haven't been uplifted yet). Please mark the dependencies or post a branch-specific patch.

          status-b2g-v2.0:
          --- → affected

          status-b2g-v2.1:
          --- → fixed
Flags: needinfo?(dmarcos)
Keywords: branch-patch-needed
Target Milestone: --- → 2.1 S1 (1aug)

    
    

    
  
This one doesn't need to be uplifted to 2.0. This fix is included in bug 1038172 that has not landed yet in 2.0. 

bug 1038172 is already merged in master hence the need of this follow up bug for the regression.
Flags: needinfo?(dmarcos) → needinfo?(jsmith)

    
    

    
  
We should unflag this as a blocker

    
    

    
  
ok
blocking-b2g: 2.0+ → ---
Flags: needinfo?(jsmith)

    
  
Depends on: 1038172

    
    

    
  
Hi Diego,
Could you please provide the detailed reproduce steps for me to verify this bug. :)
Flags: needinfo?(dmarcos)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: