If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

glodaFacetView.css references non-existing attachment-col.png

RESOLVED FIXED in Thunderbird 34.0

Status

Thunderbird
Theme
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: merike, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 34.0
All
Linux
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird33 fixed, thunderbird34 fixed, thunderbird_esr3133+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
https://hg.mozilla.org/comm-central/file/df1638ab2691/mail/themes/linux/mail/glodaFacetView.css#l22

There doesn't seem to be any attachment-col.png in the tree just attachment-col.svg: https://hg.mozilla.org/comm-central/file/df1638ab2691/mail/themes/linux/mail/icons
(Assignee)

Comment 1

3 years ago
Created attachment 8465569 [details] [diff] [review]
Patch

I checked it's the only occurrence of attachment-col.png in Linux. Using now the svg image.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8465569 - Flags: review?(josiah)
Attachment #8465569 - Flags: review?(josiah) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Pushed per Standard8's request.

https://hg.mozilla.org/comm-central/rev/11d9268bc3a0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
(Assignee)

Comment 3

3 years ago
Comment on attachment 8465569 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: no attachment icon shown
Testing completed (on c-c, etc.): in c-c
Risk to taking this patch (and alternatives if risky): really low
Attachment #8465569 - Flags: approval-comm-esr31?
Attachment #8465569 - Flags: approval-comm-beta?
Attachment #8465569 - Flags: approval-comm-aurora?
Comment on attachment 8465569 [details] [diff] [review]
Patch

a=me for aurora, too late for beta in this cycle.
Attachment #8465569 - Flags: approval-comm-beta?
Attachment #8465569 - Flags: approval-comm-aurora?
Attachment #8465569 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/737227f17593
status-thunderbird33: --- → fixed
Attachment #8465569 - Flags: approval-comm-esr31? → approval-comm-esr31+
Keywords: checkin-needed
Whiteboard: checkin-needed-on-esr31
https://hg.mozilla.org/releases/comm-esr31/rev/7d438d950f40
status-thunderbird_esr31: --- → fixed
tracking-thunderbird_esr31: --- → 33+
Keywords: checkin-needed
Whiteboard: checkin-needed-on-esr31
status-thunderbird34: --- → fixed
(Assignee)

Updated

3 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.