1046330 - [Rocketbar] App title does not appear after a swipe in fullscreen apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

A regression from bug 1039519, but let's fix it in place.

Comment 1

[Kevin Grandon :kgrandon]

Vivien - previously we were just animating the .titlebar element, but it looks like the title has been moved out and placed in the .chrome container now. Any preference as to how to solve this?

I supposed we could either try to nest the elements in a common container, or try translating both elements at the same time.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Kevin Grandon :kgrandon from comment #0)
> A regression from bug 1039519, but let's fix it in place.

Do you think we need to block on this for 2.1?

Comment 3

[Kevin Grandon :kgrandon]

(In reply to Jason Smith [:jsmith] - At Work Week, Slow to Respond from comment #2)
> (In reply to Kevin Grandon :kgrandon from comment #0)
> > A regression from bug 1039519, but let's fix it in place.
> 
> Do you think we need to block on this for 2.1?

I don't think it's necessary to block, but we are going to fix it. This stuff is really turbulent right now, so I'd just call this feature work.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey Vivien - Could you review this patch? It's not perfect as there's no transitions, but it at least shows the titlebar, and we will work on transitions next.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8467412 [details] [review]
Github pull request

r+ with nits. Thanks for fixing it.

Comment 6

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/ac4a702408a8b470677d2dba8771aa5a05d32d6c