Cannot download loop-client.zip file and run code

RESOLVED WONTFIX

Status

Hello (Loop)
Client
P5
normal
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: pdehaan, Unassigned)

Tracking

unspecified
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tech-debt][good first bug])

(Reporter)

Description

4 years ago
### Steps to reproduce:
1. Download https://github.com/mozilla/loop-client/releases/tag/0.3.2
2. unzip code.
3. run `make config` from the /loop-client-0.3.2/ directory.


### Actual results:
```
$ make config
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
```


### Expected results:
It shouldn't fail if the directory isnt an hg or git repo (which it wouldn't be if you downloaded a standalone release ZIP).


### Workaround:
Comment out the following code:

```
# Try hg first, if not fall back to git.
# SOURCE_STAMP := $(shell hg parent --template '{node|short}\n' 2> /dev/null)
# ifndef SOURCE_STAMP
# SOURCE_STAMP := $(shell git describe --always --tag)
# endif

# SOURCE_DATE := $(shell hg parent --template '{date|date}\n' 2> /dev/null)
# ifndef SOURCE_DATE
# SOURCE_DATE := $(shell git log -1 --format="%H%n%aD")
# endif
```
(Reporter)

Comment 1

4 years ago
Actually, http://localhost:3000/ and http://localhost:3000/test/ doesn't work either when downloading and installing from the ZIP file.

http://localhost:3000/         - "Cannot GET /" 
http://localhost:3000/content/ - "Loop - Welcome to the Loop web client."
http://localhost:3000/test/    - "Cannot GET /test/"
Whiteboard: [tech-debt]

Updated

3 years ago
backlog: --- → Fx36+

Updated

3 years ago
backlog: Fx36+ → Fx37+

Updated

3 years ago
backlog: Fx37+ → backlog
Whiteboard: [tech-debt] → [tech-debt][good first bug]

Updated

3 years ago
backlog: backlog → tech-debt
Priority: -- → P5
We're not publishing the zip file any more, so marking this as wontfix.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.