Closed Bug 1046425 Opened 10 years ago Closed 9 years ago

Code tidying in BaseProxyHandler::set

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jorendorff, Assigned: mz_mhs-ctb)

Details

Attachments

(1 file)

BaseProxyHandler::set contains two apparently identical code paths. No idea why. My patch in bug 1043690 makes it even clearer how odd this is.

The only difference I see between the two paths is a different error message. I'm now told that that is a bug. *sigh*
Assignee: nobody → mz_mhs-ctb
Attachment #8465541 - Flags: review?(efaustbmo)
Comment on attachment 8465541 [details] [diff] [review]
cleanup-proxyhandler-set.patch

Review of attachment 8465541 [details] [diff] [review]:
-----------------------------------------------------------------

The net effect of this patch landed months ago, when Jason came through and rewrote much of the defineProperty paths. We can close this bug.
Attachment #8465541 - Flags: review?(efaustbmo)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: