Closed Bug 1046493 Opened 5 years ago Closed 5 years ago

testVideoDiscovery.js is going to start perma-failing when Aurora 33 is merged to Beta

Categories

(Firefox for Android :: Screencasting, defect, critical)

ARM
Android
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 34
Tracking Status
firefox32 --- unaffected
firefox33 --- verified
firefox34 --- verified
fennec 33+ ---

People

(Reporter: RyanVM, Assigned: wesj)

References

Details

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=44938691&tree=Try

18:51:19     INFO -  775 INFO TEST-UNEXPECTED-FAIL | testVideoDiscovery | testVideoDiscovery.js - simple video with mp4 src - See following stack:

In case you need help reproducing, here's the patch used to simulate Aurora-as-Beta:
https://hg.mozilla.org/try/rev/aca4d5ebb66f
Wes - Can you add some code to either enable the preference or just skip the test based on the preference?

http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#284
Assignee: nobody → wjohnston
Note: If everything goes as planned, the code in mobile.js will be removed anyway and casting will be enabled by default:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#284
tracking-fennec: --- → ?
tracking-fennec: ? → 33+
Attached patch PatchSplinter Review
Lets just flip this pref on for test runs. I think this will work?
Attachment #8471072 - Flags: review?(gbrown)
Comment on attachment 8471072 [details] [diff] [review]
Patch

Review of attachment 8471072 [details] [diff] [review]:
-----------------------------------------------------------------

That will change that pref for all robocop tests.

You might be able to use this technique instead, if you prefer: http://hg.mozilla.org/mozilla-central/annotate/97628c0d8bbe/mobile/android/base/tests/testSettingsMenuItems.java#l157
Attachment #8471072 - Flags: review?(gbrown) → review+
https://hg.mozilla.org/mozilla-central/rev/9bf6a72021c3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Wes - This will needs an uplift to Fx33
Flags: needinfo?(wjohnston)
Thanks for the patch, Wes!

https://hg.mozilla.org/releases/mozilla-aurora/rev/d4982a4bbb4d
Flags: needinfo?(wjohnston)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.