1046493 - testVideoDiscovery.js is going to start perma-failing when Aurora 33 is merged to Beta

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=44938691&tree=Try

18:51:19     INFO -  775 INFO TEST-UNEXPECTED-FAIL | testVideoDiscovery | testVideoDiscovery.js - simple video with mp4 src - See following stack:

In case you need help reproducing, here's the patch used to simulate Aurora-as-Beta:
https://hg.mozilla.org/try/rev/aca4d5ebb66f

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - Can you add some code to either enable the preference or just skip the test based on the preference?

http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#284

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Note: If everything goes as planned, the code in mobile.js will be removed anyway and casting will be enabled by default:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#284

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

Lets just flip this pref on for test runs. I think this will work?

Comment 4

[Geoff Brown [:gbrown]]

Comment on attachment 8471072 [details] [diff] [review]
Patch

Review of attachment 8471072 [details] [diff] [review]:
-----------------------------------------------------------------

That will change that pref for all robocop tests.

You might be able to use this technique instead, if you prefer: http://hg.mozilla.org/mozilla-central/annotate/97628c0d8bbe/mobile/android/base/tests/testSettingsMenuItems.java#l157

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/9bf6a72021c3

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9bf6a72021c3

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - This will needs an uplift to Fx33

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Thanks for the patch, Wes!

https://hg.mozilla.org/releases/mozilla-aurora/rev/d4982a4bbb4d