1046549 - MP4 video can't be played (file is corrupt)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Various mp4 failed to play.
Firefox giving:
the video can't be played because the file is corrupt.

Analysis of the mp4 file shows that the issue occurs when the mdat track is found before the moof one.

Example:
http://people.mozilla.org/~jyavenard/mediatest/BreakVDA.mp4

The file mentioned in bug #906422 also exhibit the same problem when using libstagefright

Same with some of the files mentioned in Bug #987894

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: ignore mdat unless we've already found a media track

Bug 1046549 - Fix playback of some MP4 files

Comment 2

[Jean-Yves Avenard [:jya]]

Note: I believe we could completely remove the handling of mdat.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8465222 [details] [diff] [review]
ignore mdat unless we've already found a media track

Review of attachment 8465222 [details] [diff] [review]:
-----------------------------------------------------------------

The patch description is wrong. We used to stop parsing when we reach the 'mdat' but now we only stop parsing at the 'mdat' if we've already processed the 'moov'.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: ignore mdat unless we've already processed a moov

Bug 1046549 - Carrying r+

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a00eb18ea06

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1a00eb18ea06