Closed Bug 1046549 Opened 7 years ago Closed 7 years ago

MP4 video can't be played (file is corrupt)

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jya, Assigned: jya, Mentored)

References

Details

Attachments

(1 file, 1 obsolete file)

Various mp4 failed to play.
Firefox giving:
the video can't be played because the file is corrupt.

Analysis of the mp4 file shows that the issue occurs when the mdat track is found before the moof one.

Example:
http://people.mozilla.org/~jyavenard/mediatest/BreakVDA.mp4

The file mentioned in bug #906422 also exhibit the same problem when using libstagefright

Same with some of the files mentioned in Bug #987894
See Also: → 906422, 987894
Bug 1046549 - Fix playback of some MP4 files
Attachment #8465222 - Flags: review?(ajones)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Note: I believe we could completely remove the handling of mdat.
Comment on attachment 8465222 [details] [diff] [review]
ignore mdat unless we've already found a media track

Review of attachment 8465222 [details] [diff] [review]:
-----------------------------------------------------------------

The patch description is wrong. We used to stop parsing when we reach the 'mdat' but now we only stop parsing at the 'mdat' if we've already processed the 'moov'.
Attachment #8465222 - Flags: review?(ajones) → review+
Attachment #8465222 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/1a00eb18ea06
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.