ignore AttributeChanged notifications before initial reflow

VERIFIED FIXED in mozilla0.9.6

Status

()

defect
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: waterson, Assigned: waterson)

Tracking

({perf})

Trunk
mozilla0.9.6
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

18 years ago
I've noticed that we're getting a lot of ReconstructFramesForContent() calls
while loading XUL documents; it turns out that we can squelch a bunch of these
by simply making the PresShell ignore AttributeChanged notifications before the
intial reflow has occurred.

This ought to nominally improve new window performance, for example.
Assignee

Updated

18 years ago
Blocks: 49141
Assignee

Updated

18 years ago
No longer blocks: 49141
Status: NEW → ASSIGNED
Keywords: patch, perf
Priority: -- → P3
Target Milestone: --- → mozilla0.9.6
Yeah, the "morse code" for bringing up a new window shows about 40
attribute-change notifications wandering through the style system, so this can't
hurt at all.

(Did you want me to review?)

Comment 3

18 years ago
Comment on attachment 53446 [details] [diff] [review]
diff -wu, only notify style set if we've done an initial reflow

sr=attinasi
Attachment #53446 - Flags: superreview+

Updated

18 years ago
Blocks: 49141
Comment on attachment 53446 [details] [diff] [review]
diff -wu, only notify style set if we've done an initial reflow

r=dbaron
Attachment #53446 - Flags: review+
Assignee

Comment 5

18 years ago
Fix checked in. We might want to consider moving the BeginObservingDocument()
call to _after_ the initial reflow, so we can squelch other notifications that
won't do anything. I've put a comment to that effect in the code.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
Marking verified in the Oct 22nd branch builds.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.