1046735 - In file " nss/lib/softoken/legacydb/lowcert.c" in function "nsslowcert_EmailName" a null check has been done for wrong variable.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Sachin Kumar Gupta]

Attachment: Proposed Patch.

Error:
 The second null check for "oid" at line number 450 should have been a null check for variable "name" instead.

 
NSS 3.16.3 version code:

     oid=nsslowcert_dataStart(ava, ava_length, &oid_length, PR_FALSE, NULL);
      if (oid == NULL) { return NULL;  }
      ava_length -= (oid-ava)+oid_length;
      ava = oid+oid_length;

      name=nsslowcert_dataStart(ava, ava_length, &name_length, PR_FALSE, NULL);
      if (oid == NULL) { return NULL; }

 

Recommended code:

      oid=nsslowcert_dataStart(ava, ava_length, &oid_length, PR_FALSE,NULL);
      if (oid == NULL) { return NULL; }
      ava_length -= (oid-ava)+oid_length;
      ava = oid+oid_length;

      name=nsslowcert_dataStart(ava, ava_length, &name_length, PR_FALSE,NULL);
      if (name == NULL) { return NULL; }

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8465399 [details] [diff] [review]
Proposed Patch.

Review of attachment 8465399 [details] [diff] [review]:
-----------------------------------------------------------------

Bob is probably the best reviewer for this patch.

Comment 2

[Sachin Kumar Gupta]

Reminder for code check in.

Comment 3

[Wan-Teh Chang]

Comment on attachment 8465399 [details] [diff] [review]
Proposed Patch.

Review of attachment 8465399 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. Thanks for the patch. I also checked the entire function and found
no other bug of this kind.

Patch checked in: https://hg.mozilla.org/projects/nss/rev/667b72ac012d

Comment 4

[Wan-Teh Chang]

Kai: please include this fix in NSS 3.17.