Closed Bug 1046744 Opened 10 years ago Closed 9 years ago

Write tests to check that we gracefully close connections on successful ended calls

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME
Blocking Flags:
backlog Fx37+

People

(Reporter: NiKo, Unassigned)

Details

(Whiteboard: [tech-debt]) 

In loop/test/desktop-local/conversation_test.js, we have this comment which needs to be addressed:

> XXX When the call is ended gracefully, we should check that we 
> close connections nicely
Whiteboard: [tech-debt]
backlog: --- → Fx36+
backlog: Fx36+ → Fx37+
Priority: -- → P2
Priority: P2 → P1
Priority: P1 → P2
this may be going away
Flags: needinfo?(standard8)
No longer applicable - we've removed the XXX that said this, and with the new flux code, we're going to have tests at the unit level that checks this works.

Hence marking as wfm.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(standard8)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.