Closed Bug 1046759 Opened 9 years ago Closed 9 years ago

sub-jobs, e.g. mochitest, sort lexicographically, not numerically

Categories

(Tree Management :: Treeherder, defect, P2)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: froydnj, Assigned: camd)

References

Details

Attachments

(2 files)

treeherder screenshot showing multiple ways of arranging jobs
284.24 KB, image/png
Details
Pull request 215
54 bytes, text/x-github-pull-request
jeads
: review+
Details | Review 
For platforms where mochitest is split up into many sub-suites (e.g. B2G), the treeherder display shows them as:

1 10 11 12 ... 2 3 4 5...

versus the arguably better TBPL sorting:

1 2 3 4 5...10 11 12...
Summary: sub-jobs, e.g. mochitest, sort lexicogrphically, not numerically → sub-jobs, e.g. mochitest, sort lexicographically, not numerically
Marking blocking since this makes it harder to side by side compare TBPL to treeherder.
Blocks: treeherder-sheriff-transition
Priority: -- → P2
Actually, the sorting for treeherder jobs seems to be all over the map.
(In reply to Nathan Froyd (:froydnj) from comment #2)
> Actually, the sorting for treeherder jobs seems to be all over the map.

That is likely bug 1057381.
Assignee: nobody → kwierso
Status: NEW → ASSIGNED
Camd wrote the patch, I just linked it. :)
Assignee: kwierso → cdawson
Comment on attachment 8488333 [details] [review]
Pull request 215

(Patch by Cameron; marking for review so the PR doesn't get missed).
Attachment #8488333 - Flags: review?(jeads)
Attachment #8488333 - Flags: review?(jeads) → review+
This had r+, is this ready to merge? :-)
Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/ae7b3b66180acd8a26fb2b48ebc93658a9c4a764
bug 1046759 - make job symbols show in numerical order correctly

https://github.com/mozilla/treeherder-service/commit/7823ad38831527959b04428c82e684a494b0b84c
Merge pull request #215 from mozilla/bug-1046759-job-order

bug 1046759 - make job symbols show in numerical order correctly
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.