1046759 - sub-jobs, e.g. mochitest, sort lexicographically, not numerically

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Nathan Froyd [:froydnj]]

For platforms where mochitest is split up into many sub-suites (e.g. B2G), the treeherder display shows them as:

1 10 11 12 ... 2 3 4 5...

versus the arguably better TBPL sorting:

1 2 3 4 5...10 11 12...

Comment 1

[Ed Morley [:emorley]]

Marking blocking since this makes it harder to side by side compare TBPL to treeherder.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: treeherder screenshot showing multiple ways of arranging jobs

Actually, the sorting for treeherder jobs seems to be all over the map.

Comment 3

[Ed Morley [:emorley]]

(In reply to Nathan Froyd (:froydnj) from comment #2)
> Actually, the sorting for treeherder jobs seems to be all over the map.

That is likely bug 1057381.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Pull request 215

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Camd wrote the patch, I just linked it. :)

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8488333 [details] [review]
Pull request 215

(Patch by Cameron; marking for review so the PR doesn't get missed).

Comment 7

[Ed Morley [:emorley]]

This had r+, is this ready to merge? :-)

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/ae7b3b66180acd8a26fb2b48ebc93658a9c4a764
bug 1046759 - make job symbols show in numerical order correctly

https://github.com/mozilla/treeherder-service/commit/7823ad38831527959b04428c82e684a494b0b84c
Merge pull request #215 from mozilla/bug-1046759-job-order

bug 1046759 - make job symbols show in numerical order correctly