1046761 - youtube displays the browser context menu in e10s windows

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Jim Mathies [:jimm]]

Attachment: youtube.png

STR:

1) disable or uninstall flash (uninstall is best!)
2) open a new e10s window
3) visit youtube, view an html5 video
4) right click on the video

In non-e10s windows, we get the youtube menu, in e10s windows, we get the youtube and browser context menus.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: contextmenu

Without e10s, we end up here:
http://mxr.mozilla.org/mozilla-central/source/content/xul/content/src/nsXULPopupListener.cpp#105

That code checks the defaultPrevented property on the event and also some other stuff. In e10s, the event is generated in the context process and there's no XUL for the popup listener to be attached to, so we never hit that code.

What it does for content seems to be pretty simple, so I just implemented it in a little JS.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a50d9d53bdff

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a50d9d53bdff

Comment 5

[kenkon]

[bugday-20140910]

This bug is fixed in Aurora 34.0a2 (buildID 20140910004000). Please set status-firefox34 to verified for me ;)

Comment 6

[Bogdan Maris, Desktop QA]

Thanks kenkon :) Marking this as verified based on comment 5.