Closed Bug 1046784 Opened 5 years ago Closed 5 years ago

move -DNOMINMAX definitions to moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Straightforward patch.
Attachment #8465462 - Flags: review?(mshal)
Assignee: nobody → nfroyd
Blocks: nomakefiles
I never understood why we set this on a per-directory basis.  Do we have any code which we want to build without -DNOMINMAX?!
Comment on attachment 8465462 [details] [diff] [review]
move -DNOMINMAX definitions to moz.build

I don't know why it's done on a per-directory basis either. I'd guess everytime someone hits the error, it gets added as a one-off. I did find some history:

https://bugzilla.mozilla.org/show_bug.cgi?id=786533#c43

and:

https://bugzilla.mozilla.org/show_bug.cgi?id=830801

r+ for now since the patch maintains parity with the existing setup. Up to nfroyd if you want to try just deleting them all and setting it globally for Windows. (Patches that just delete a million lines are the best! :)
Attachment #8465462 - Flags: review?(mshal) → review+
Sorry I didn't mean to block this patch.  Just thinking out loud.  :-)
(In reply to :Ehsan Akhgari (Back on 8/5 - not reading bugmail, needinfo? me!) from comment #4)
> Sorry I didn't mean to block this patch.  Just thinking out loud.  :-)

Don't worry!  Ignoring scope creep requests is one of my superpowers. ;)
https://hg.mozilla.org/mozilla-central/rev/26d8874e7fdc
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
> Ignoring scope creep requests is one of my superpowers. ;)

What are the others? Inquiring minds wish to know.
Blocks: 1049936
QA Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.