Replace shared/elements/gaia_header with external component

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wilsonpage, Assigned: wilsonpage)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8465564 [details] [review]
pull-request (master)

Yan, I'm going to land the gaia-header shared stuff in this bug so we're not dependant on the Video patch landing as it seems to be taking longer than I thought.

Could you give this a quick check and then we can land it to make our lives a bit easier :)
Attachment #8465564 - Flags: review?(yor)
(Assignee)

Updated

4 years ago
Blocks: 1015249

Comment 2

4 years ago
Comment on attachment 8465564 [details] [review]
pull-request (master)

Looks fine.  I assume this is just a bower installed checkin and that any changes should still be done in gaia-components/gaia-header.
Attachment #8465564 - Flags: review?(yor) → review+
(Assignee)

Comment 3

4 years ago
Landed on 'master'

https://github.com/mozilla-b2g/gaia/commit/0902a335ff297faf5eae18b6759876a7f7ec0693
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

4 years ago
yan: Now that this has landed, we can remove the dependency on the Video patch for each of the apps, rebase against master and begin to land stuff. NI just to confirm this is cool with you?
Flags: needinfo?(yor)

Comment 5

4 years ago
Great!  I'll get right to it next week (on vacation this week).
Flags: needinfo?(yor)
Depends on: 1054794
Depends on: 1054797
You need to log in before you can comment on or make changes to this bug.