Closed Bug 1046822 Opened 11 years ago Closed 11 years ago

Use express-hawkauth rather than our own version of it

Categories

(Cloud Services Graveyard :: MobileID, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: alexis+bugs, Assigned: rhubscher)

Details

(Whiteboard: [qa?])

Attachments

(1 file, 1 obsolete file)

59 bytes, text/x-github-pull-request
alexis+bugs
: review+
Details | Review
We should use the express-hawkauth to do authentication with hawk rather than rely on our own version of it (before we packaged it)
Whiteboard: [qa?]
Can you give some details here? Benefits vs. costs? Also, do we have any other services currently using express-hawkauth vs. our own?
There are losts of benefits: - Security / Bug fix made at the same time on all services - DRY: Make stuff once good for all and care about your service. In terms of cost few hours should do it.
James, express-hawk is the code that used to leave in there that was factorized and put together as a library.
Assignee: nobody → rhubscher
Status: NEW → ASSIGNED
Attached file Link to github PR (obsolete) —
Attachment #8475042 - Attachment is obsolete: true
Attached file Link to github PR
Attachment #8475048 - Flags: review?(alexis+bugs)
Attachment #8475048 - Flags: review?(alexis+bugs) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified in code.
Status: RESOLVED → VERIFIED
Product: Cloud Services → Cloud Services Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: