Closed Bug 1046839 Opened 10 years ago Closed 10 years ago

Unnecessary double cloneInto in mozSettings

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

cloneInto.patch
1.13 KB, patch
bholley
: review+
Details | Diff | Splinter Review 
https://mxr.mozilla.org/mozilla-central/source/dom/settings/SettingsManager.js#147 does a this._wrap (that calls CloneInto) but then in line 151 we do the same again.
Attached patch cloneInto.patch — — Splinter Review 

        Attachment #8465543 -
        Flags: review?(bobbyholley)

        Attachment #8465543 -
        Flags: review?(bobbyholley) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f644ef79d9ee
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: