1046876 - "Cu is not defined" in NetworkGeolocationProvider.js

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[:gerard-majax]

While playing with my Nexus S running master in the train:

07-31 19:02:47.082  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.086  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.101  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.105  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.109  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.113  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.254  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.254  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.265  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]
07-31 19:02:47.265  2910  2910 E GeckoConsole: [JavaScript Error: "Cu is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkGeolocationProvider.js" line: 518}]

Comment 1

[:garvan]

due to change in bug 1034301?

Comment 2

[Josh Matthews [:jdm]]

Yep. Simple fix is adding to the list at http://mxr.mozilla.org/mozilla-central/source/dom/system/NetworkGeolocationProvider.js#9.

Comment 3

[Aus Lacroix [:aus]]

(In reply to Garvan Keeley [:garvank] from comment #1)
> due to change in bug 1034301?

Yup, looks like it. I swear there was other usage of Cu in there but I guess not. Do you guys want me to take this or were we just trying to determine what change introduced this?

Comment 4

[Aus Lacroix [:aus]]

Patch incoming...

Comment 5

[Aus Lacroix [:aus]]

Attachment: Patch - v1 - Define 'Cu'

Comment 6

[Aus Lacroix [:aus]]

Comment on attachment 8465719 [details] [diff] [review]
Patch - v1 - Define 'Cu'

Approval Request Comment
[Feature/regressing bug #]: 1034301
[User impact if declined]: Original issue reported in 1034301 will persist.
[Describe test coverage new/current, TBPL]:
[Risks and why]: None.
[String/UUID change made/needed]: None.

Comment 7

[Aus Lacroix [:aus]]

Commit (b2g-inbound): https://hg.mozilla.org/integration/b2g-inbound/rev/841bd5ad4ca7

Leave open until decision to land on aurora is complete.

Comment 8

[Aus Lacroix [:aus]]

[Blocking Requested - why for this release]:

Comment 9

[Gregor Wagner [:gwagner]]

zero risk patch.

Comment 10

[Aus Lacroix [:aus]]

Comment on attachment 8465719 [details] [diff] [review]
Patch - v1 - Define 'Cu'

2.0+ gets automatic aurora approval.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/841bd5ad4ca7

Comment 12

[Ryan VanderMeulen [:RyanVM]]

And by "aurora" you mean b2g32 since we branched ~2w ago ;)

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/2b6d88a8445a