Closed Bug 1046908 Opened 6 years ago Closed 6 years ago

[Rocketbar] Cleanup legacy DOM

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
There's a bunch of legacy dom content/rocketbar logic that is now duplicated by app chrome/title and can be removed.
Attached file Github pull request
Hey Dale, Vivien - could either of you guys review this patch? It's just ripping out a bunch of unused code for the old rocketbar implementation. Thanks!
Attachment #8465724 - Flags: review?(dale)
Attachment #8465724 - Flags: review?(21)
Comment on attachment 8465724 [details] [review]
Github pull request

Less code. Less bug. LGTM.
Attachment #8465724 - Flags: review?(21) → review+
Attachment #8465724 - Flags: review?(dale)
Master: https://github.com/mozilla-b2g/gaia/commit/bd8ef5e1e7c9afe2c46736f3d1e6bd46be31bf4f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.