Closed Bug 1046998 Opened 10 years ago Closed 10 years ago

Modify test_copyThenMoveManual.js to use Promises

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(thunderbird34 fixed)

RESOLVED FIXED
Thunderbird 34.0
Tracking Status
thunderbird34 --- fixed

People

(Reporter: sshagarwal, Assigned: sshagarwal)

References

Details

Attachments

(1 file, 1 obsolete file)

We intend to replace async calls with promises.
This is another attempt in the same direction.
Attached patch b1046998.patch (obsolete) — Splinter Review
Attachment #8465701 - Flags: review?(kent)
Depends on: 1024053
Comment on attachment 8465701 [details] [diff] [review]
b1046998.patch

Review of attachment 8465701 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one nit fixed.

::: mailnews/base/test/unit/test_copyThenMoveManual.js
@@ +85,5 @@
>      // operation was a move
>      do_check_eq(folderCount(localAccountUtils.inboxFolder), 0);
> +  },
> +  function endTest() {
> +    // Cleanup, null out everything, close all cached connections and stop the 

Nit: trailing space
Attachment #8465701 - Flags: review?(kent) → review+
Thanks.
Assignee: nobody → syshagarwal
Attachment #8465701 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8471039 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/0ba79665d6fc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: