Closed
Bug 1046998
Opened 10 years ago
Closed 10 years ago
Modify test_copyThenMoveManual.js to use Promises
Categories
(MailNews Core :: Testing Infrastructure, defect)
MailNews Core
Testing Infrastructure
Tracking
(thunderbird34 fixed)
RESOLVED
FIXED
Thunderbird 34.0
Tracking | Status | |
---|---|---|
thunderbird34 | --- | fixed |
People
(Reporter: sshagarwal, Assigned: sshagarwal)
References
Details
Attachments
(1 file, 1 obsolete file)
6.60 KB,
patch
|
sshagarwal
:
review+
|
Details | Diff | Splinter Review |
We intend to replace async calls with promises. This is another attempt in the same direction.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8465701 -
Flags: review?(kent)
Comment 2•10 years ago
|
||
Comment on attachment 8465701 [details] [diff] [review] b1046998.patch Review of attachment 8465701 [details] [diff] [review]: ----------------------------------------------------------------- r=me with one nit fixed. ::: mailnews/base/test/unit/test_copyThenMoveManual.js @@ +85,5 @@ > // operation was a move > do_check_eq(folderCount(localAccountUtils.inboxFolder), 0); > + }, > + function endTest() { > + // Cleanup, null out everything, close all cached connections and stop the Nit: trailing space
Attachment #8465701 -
Flags: review?(kent) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks.
Assignee: nobody → syshagarwal
Attachment #8465701 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8471039 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/0ba79665d6fc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
Updated•10 years ago
|
status-thunderbird34:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•