dom/plugins/ipc/PluginModuleChild.cpp:280:60: error: 'gdk_window_get_screen' was not declared in this scope on Gtk+3 builds on elm

RESOLVED FIXED in mozilla34

Status

RESOLVED FIXED
4 years ago
7 months ago

People

(Reporter: glandium, Assigned: froydnj)

Tracking

unspecified
mozilla34
All
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
https://tbpl.mozilla.org/?tree=Elm&rev=935ab6167c6d

The only change between last green and this red that touches dom/plugins/ipc is bug 1042878.
(Assignee)

Comment 3

4 years ago
Created attachment 8466259 [details] [diff] [review]
move MOZ_GTK*_CFLAGS hacking from config.mk to configure.in

This move ensures that other makefile variables that reference
MOZ_GTK*_CFLAGS, e.g. TK_CFLAGS, will always have a consistent view of
MOZ_GTK*_CFLAGS.

(This happens because, even though TK_CFLAGS is literally $(MOZ_GTK_CFLAGS), we
weren't twiddling with MOZ_GTK_CFLAGS until *after* backend.mk got included.
Which caused problems when we moved things from:

OS_CXXFLAGS += $(TK_CFLAGS)

in Makefile.in to:

CXXFLAGS += CONFIG['TK_CFLAGS']

in moz.build, as things got evaluated in a different order.  I think.)
Attachment #8466259 - Flags: review?(mshal)
(Assignee)

Comment 4

4 years ago
GTK+3 try run: https://tbpl.mozilla.org/?tree=Try&rev=ad925183f376

Builds fine for me locally, with GTK+2.
(Reporter)

Updated

4 years ago
Attachment #8466259 - Flags: review?(mshal) → review+
(Reporter)

Comment 5

4 years ago
(In reply to Nathan Froyd (:froydnj) from comment #3)
> Which caused problems when we moved things from:
> 
> OS_CXXFLAGS += $(TK_CFLAGS)
> 
> in Makefile.in to:
> 
> CXXFLAGS += CONFIG['TK_CFLAGS']
> 
> in moz.build, as things got evaluated in a different order.  I think.)

It's actually simpler than that. It's because some moz.builds have CXXFLAGS += CONFIG['MOZ_GTK2_CFLAGS'] during the gtk3 build.
(Assignee)

Comment 6

4 years ago
Mike had said something about landing this directly on central, but that was Friday evening...I figure things will be merged to central or close to it by the time he wakes up:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca2ba3cafed7
Assignee: nobody → nfroyd
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/ca2ba3cafed7
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]

Updated

7 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.