1047213 - [Calendar] Changing language will not reflect all strings in new language.

Status: RESOLVED DUPLICATE of bug 1030809

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Comment 1

[swathiks115]

 On switching to other language will not change all strings in new language.

steps to reproduce.
1. open calendar.
2. Go to day view.
3. press home button.
4. open settings-> change language -> press home button 
5. open calendar.
6. Strings are not displayed in new language.

Comment 2

[Kevin Grandon :kgrandon]

Hmm, not sure if we need to listen to the localized event or not. It seems like we are probably not using the right l10n-id usage in the Calendar, and maybe need to update our L10n usage.

Comment 3

[swathiks115]

But if we kill the application and reopen it is translating, so I think this is not because of l10n-id usage.

Comment 4

[Kevin Grandon :kgrandon]

My hunch is that this is because we are setting textContent instead of using data-l10n-id. Gandalf, is that correct?

Do you know if we have any bugs for this filed for calendar? Thanks!

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

That's very possible. There are 35 uses of mozL10n.get in Calendar. 

Reporter, can you provide me an example screenshot with untranslated content? I'll try to debug it to confirm Kevin's hypothesis.

Comment 6

[Miller Medeiros [:millermedeiros]]

We have a bunch of bugs filled for this kind of errors, but was not able to fix all of them before 2.0 FC.. on 2.1 we will rewrite some of the views so that's why this work was deferred. This is an edge case and won't be considered as a blocker.

PS: I have a patch that fixes this on Bug 1030809, I might merge it later today (already r+, just need to rebase and make sure it doesn't break the build).

Comment 7

[swathiks115]

Patch in Bug 1030809 will resolve this issue only in day view.
In week view still the time bar strings are not reflected.
Please check this


Thanks!

Comment 8

[Miller Medeiros [:millermedeiros]]

we have another bug dedicated for the week view (see Bug 1030804).

Comment 9

[swathiks115]

In event details view, switching language will not reflect to new language.
i.e select saved event-> event details 
Do we have any bug for this issue?

Comment 10

[Miller Medeiros [:millermedeiros]]

All the L10n bugs that I'm aware of (that was introduced by the visual refresh) are flagged on the [meta] Bug 1027360.. maybe we should create a new [meta] just for localization (each view as a separate bug, since we work on them individually).