Closed
Bug 1047225
Opened 11 years ago
Closed 11 years ago
The check added in bug 442629 is not running anymore
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
2.75 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
While going through Makefiles seeking for EXTRA_LIBS, I stumbled upon this snippet from uriloader/exthandler/tests/Makefile.in:
ifdef MOZ_WIDGET_GTK
export PERSONAL_MAILCAP=$(abspath $(srcdir))/mailcap
endif
There is nothing more in the Makefile that makes use of that variable. Digging a bit, it used to be used by the test added in bug 442629 in the ancient time we were running xpcshell tests from within the build tree.
Which means moving the test in an off-the-tree job made it stop doing this check.
(Coincidentally, I'm the one who wrote that test 6 years ago)
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8466015 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8466015 [details] [diff] [review]
Properly run the test from bug 442629
r=me. Nice catch!
Attachment #8466015 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•