All users were logged out of Bugzilla on October 13th, 2018

The check added in bug 442629 is not running anymore

RESOLVED FIXED in mozilla34

Status

RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla34
All
Linux
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
While going through Makefiles seeking for EXTRA_LIBS, I stumbled upon this snippet from uriloader/exthandler/tests/Makefile.in:

ifdef MOZ_WIDGET_GTK
export PERSONAL_MAILCAP=$(abspath $(srcdir))/mailcap
endif

There is nothing more in the Makefile that makes use of that variable. Digging a bit, it used to be used by the test added in bug 442629 in the ancient time we were running xpcshell tests from within the build tree.

Which means moving the test in an off-the-tree job made it stop doing this check.

(Coincidentally, I'm the one who wrote that test 6 years ago)
(Assignee)

Comment 1

4 years ago
Created attachment 8466015 [details] [diff] [review]
Properly run the test from bug 442629
Attachment #8466015 - Flags: review?(bzbarsky)
(Assignee)

Updated

4 years ago
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 8466015 [details] [diff] [review]
Properly run the test from bug 442629

r=me.  Nice catch!
Attachment #8466015 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/c137239b4877
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.