1047268 - test_dirs.html should use SpecialPowers.pushPermissions instead of SpecialPowers.addPermission

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

I was trying to enable content/media/test/* on B2G emulator debug and found out it resulted in perma-failure of test_dirs.html.

We should call SpecialPowers.pushPermissions which accepts a function callback so that we can ensure permission change is complete before we continue the rest of the tests.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: fix_test_dirs_html_permission.patch

Call SpecialPowers.pushPermissions() to ensure permission change is completed before continuing the rest of the tests.

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8466060 [details] [diff] [review]
fix_test_dirs_html_permission.patch

Review of attachment 8466060 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks for finding and fixing this.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

try most green: https://tbpl.mozilla.org/?tree=Try&rev=89b406c70b87

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab3e0e1385cf

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab3e0e1385cf