1047271 - [Gallery] Image rotation is not consistence after sharing

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[ranjith253]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140724030201

Steps to reproduce:

1. Take picture a in landscape mode for example 16:9 resolution
2. Open gallery go to select mode .
3. Click on single image & try to share, select Messages option in share list.
4. Now from Message screen attach same image from gallery.


Actual results:

Observe the orientation of both attached images in step 3 & 4 .
First attachment is in landscape mode & second image in portrait mode.

I am attaching  issue screen shot.


Expected results:

Both attachments should have same orientation.

Comment 1

[ranjith253]

Attachment: Issue_screenshot.png

Comment 2

[ranjith253]

My image exif  rotation value is 90.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

What device is this happening on? What build is running on it?

Comment 4

[ranjith253]

This issue can be reproducible with latest gaia master code.

Comment 5

[ranjith253]

Clearing the flag

Comment 6

[Punam Dahiya [:pdahiya]]

To reproduce this issue one needs image that has to be rotated to display correctly (e.g. from device such as Tarako).  Here's link to sample image that can be used to replicate this bug
https://github.com/recurser/exif-orientation-examples/blob/master/Portrait_6.jpg

This behavior is expected as Gallery app does not support rotation when you share images from select mode.

https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/gallery.js#L1229

Only when user shares an image from gallery fullscreen view, it does the rotation - Bug 989290

https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/frames.js#L172

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

(Moving to gallery since this seems like a generic issue that would ideally be resolved on the gallery side of things... and the messages app rather than the email app was mentioned :)

Comment 8

[ranjith253]

Hi Punam,

Con't we support rotation from select mode?, because user may be confused with 
rotation in full screen & select mode.

Comment 9

[Punam Dahiya [:pdahiya]]

(In reply to ranjith253 from comment #8)
> Hi Punam,
> 
> Con't we support rotation from select mode?, because user may be confused
> with 
> rotation in full screen & select mode.

It will be difficult to support image rotation from select mode, as user can select multiple images for sharing and  decoding an image to rotate is memory intensive and might not scale for devices such as Tarako where this issue is more visible.

Now should we rotate the image in select mode if user selects single image for sharing, i guess not as it might be equally confusing for user to see an unrotated image if he on subsequent tries selects more than one image to share. Thanks

Comment 10

[ranjith253]

(In reply to Punam Dahiya from comment #9)
> (In reply to ranjith253 from comment #8)
> > Hi Punam,
> > 
> > Con't we support rotation from select mode?, because user may be confused
> > with 
> > rotation in full screen & select mode.
> 
> It will be difficult to support image rotation from select mode, as user can
> select multiple images for sharing and  decoding an image to rotate is
> memory intensive and might not scale for devices such as Tarako where this
> issue is more visible.
> 
> Now should we rotate the image in select mode if user selects single image
> for sharing, i guess not as it might be equally confusing for user to see an
> unrotated image if he on subsequent tries selects more than one image to
> share. Thanks

I agree to your point here , but I think there is no harm in supporting single file rotation. What do you think?

Comment 11

[Punam Dahiya [:pdahiya]]

> I agree to your point here , but I think there is no harm in supporting
> single file rotation. What do you think?

Sorry, if I was not clear in comment #9, IMO, it is confusing for user to see rotated image when he shares single image from select mode and unrotated images when he shares multiple images from gallery select mode.

Comment 12

[BMO Automation]

Firefox OS is not being worked on