1047292 - Clean up the test code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Evan Tseng [:evanxd]]

We might not need to use the `tap` method with some specified coordinates in the settings test code[1].

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/marionette/app/app.js#L218

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22398

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8466092 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22398

Hi EJ,

Could you help me to review the patch?
I think we could kill the magic number.

Thanks.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8466092 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22398

Thanks Evan ! Let's just remove this.

Comment 4

[Evan Tseng [:evanxd]]

Hi EJ,

Thanks for the review.

Comment 5

[Evan Tseng [:evanxd]]

master: 9ef7ee6031c4a7a6e2c6d9e018066a5ae484d3fc

Comment 6

[Julien Wajsberg [:julienw]]

Backed out for Gij failures
master: 23b3026caa88af4cc76e7171949ac32a7a4c8768

Note that Gaia try was red when you merged... :
Gaia try: https://tbpl.mozilla.org/?rev=5c7c893b50f8badea60ec7d56fd93a2ad009adfb&tree=Gaia-Try

Travis failure: https://travis-ci.org/mozilla-b2g/gaia/jobs/31582973