Closed
Bug 1047292
Opened 12 years ago
Closed 10 years ago
Clean up the test code
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evanxd, Assigned: evanxd)
Details
Attachments
(1 file)
We might not need to use the `tap` method with some specified coordinates in the settings test code[1].
[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/marionette/app/app.js#L218
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 8466092 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22398
Hi EJ,
Could you help me to review the patch?
I think we could kill the magic number.
Thanks.
Attachment #8466092 -
Flags: review?(ejchen)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8466092 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22398
Thanks Evan ! Let's just remove this.
Attachment #8466092 -
Flags: review?(ejchen) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Hi EJ,
Thanks for the review.
|
|
Assignee | |
Comment 5•12 years ago
|
||
master: 9ef7ee6031c4a7a6e2c6d9e018066a5ae484d3fc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 6•12 years ago
|
||
Backed out for Gij failures
master: 23b3026caa88af4cc76e7171949ac32a7a4c8768
Note that Gaia try was red when you merged... :
Gaia try: https://tbpl.mozilla.org/?rev=5c7c893b50f8badea60ec7d56fd93a2ad009adfb&tree=Gaia-Try
Travis failure: https://travis-ci.org/mozilla-b2g/gaia/jobs/31582973
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•