Closed Bug 1047297 Opened 6 years ago Closed 6 years ago

Some Clang warnings when building the ARM simulator

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jandem, Assigned: dougc)

Details

Attachments

(2 files)

Attached file Warnings
There are some warnings in IonAssemblerBufferWithConstantPools.h, see attachment.

I'd fix them myself, but it's not immediately obvious what's the right fix for some of the "comparison of integers of different signs" ones, because I don't know which values can be signed in practice.

This is with Clang 3.4.1 and --enable-debug --enable-optimize
Flags: needinfo?(dtc-moz)
(In reply to Jan de Mooij [:jandem] from comment #0)
> Created attachment 8466097 [details]
> Warnings
> 
> There are some warnings in IonAssemblerBufferWithConstantPools.h, see
> attachment.

Thanks, I'll fix it.
Assignee: nobody → dtc-moz
Flags: needinfo?(dtc-moz)
QA Contact: dtc-moz
Attachment #8466238 - Flags: review?(jdemooij)
Comment on attachment 8466238 [details] [diff] [review]
Fix some compiler warnings.

Review of attachment 8466238 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8466238 - Flags: review?(jdemooij) → review+
Keywords: checkin-needed
The above try run was busted, perhaps infrastructure. This one looks better:
https://tbpl.mozilla.org/?tree=Try&rev=e0859c87c03d
https://hg.mozilla.org/mozilla-central/rev/b3659aa5368b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.