1047297 - Some Clang warnings when building the ARM simulator

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Warnings

There are some warnings in IonAssemblerBufferWithConstantPools.h, see attachment.

I'd fix them myself, but it's not immediately obvious what's the right fix for some of the "comparison of integers of different signs" ones, because I don't know which values can be signed in practice.

This is with Clang 3.4.1 and --enable-debug --enable-optimize

Comment 1

[Douglas Crosher [:dougc]]

(In reply to Jan de Mooij [:jandem] from comment #0)
> Created attachment 8466097 [details]
> Warnings
> 
> There are some warnings in IonAssemblerBufferWithConstantPools.h, see
> attachment.

Thanks, I'll fix it.

Comment 2

[Douglas Crosher [:dougc]]

Attachment: Fix some compiler warnings.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8466238 [details] [diff] [review]
Fix some compiler warnings.

Review of attachment 8466238 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Douglas Crosher [:dougc]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=80e426dc7bde

Comment 5

[Douglas Crosher [:dougc]]

The above try run was busted, perhaps infrastructure. This one looks better:
https://tbpl.mozilla.org/?tree=Try&rev=e0859c87c03d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3659aa5368b

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b3659aa5368b