Remove the check of onremovetrack in "test_mediatrack_consuming_mediastream.html"

RESOLVED FIXED in Firefox 33

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: shelly, Assigned: shelly)

Tracking

unspecified
mozilla34
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox32 unaffected, firefox33 fixed, firefox34 fixed)

Details

(Whiteboard: [FT:Stream3])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Fix of bug 1035482, original comment in bug 1038494, comment 8.
(Assignee)

Updated

4 years ago
Summary: Fix mochitest "test_mediatrack_consuming_mediastream.html" → Remove the check of onremovetrack in "test_mediatrack_consuming_mediastream.html"
(Assignee)

Updated

4 years ago
Assignee: nobody → slin
Blocks: 1035482
Whiteboard: [FT:Stream3]
(Assignee)

Comment 1

4 years ago
Created attachment 8466124 [details] [diff] [review]
Test case fix

Hi roc, I think it should be fine to remove the check of onremovetrack on video element, because 1. It should really be checked at the onended event handler of MediaStream or the onended event handler of MediaStreamTrack, and we implement them neither, and 2. We are still checking the length of video.audioTracks and video.videoTracks.

Thanks!
Attachment #8466124 - Flags: review?(roc)
(Assignee)

Comment 2

4 years ago
Try server result with failing platform:
(Android 2.3 Emulator try opt test mochitest-4 )
https://tbpl.mozilla.org/?tree=Try&rev=0bc5c4782685

(b2g_emulator_vm try opt test mochitest-3)
https://tbpl.mozilla.org/?tree=Try&rev=72b4bd387fe4
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Comment 4

4 years ago
https://hg.mozilla.org/mozilla-central/rev/9b53034ae4c9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
https://hg.mozilla.org/releases/mozilla-aurora/rev/7671c6af65a4
status-firefox32: --- → unaffected
status-firefox33: --- → fixed
status-firefox34: --- → fixed
You need to log in before you can comment on or make changes to this bug.