Closed
Bug 1047307
Opened 10 years ago
Closed 10 years ago
Remove the check of onremovetrack in "test_mediatrack_consuming_mediastream.html"
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
Tracking | Status | |
---|---|---|
firefox32 | --- | unaffected |
firefox33 | --- | fixed |
firefox34 | --- | fixed |
People
(Reporter: shelly, Assigned: shelly)
References
Details
(Whiteboard: [FT:Stream3])
Attachments
(1 file)
1.25 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Fix of bug 1035482, original comment in bug 1038494, comment 8.
Assignee | ||
Updated•10 years ago
|
Summary: Fix mochitest "test_mediatrack_consuming_mediastream.html" → Remove the check of onremovetrack in "test_mediatrack_consuming_mediastream.html"
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Hi roc, I think it should be fine to remove the check of onremovetrack on video element, because 1. It should really be checked at the onended event handler of MediaStream or the onended event handler of MediaStreamTrack, and we implement them neither, and 2. We are still checking the length of video.audioTracks and video.videoTracks. Thanks!
Attachment #8466124 -
Flags: review?(roc)
Assignee | ||
Comment 2•10 years ago
|
||
Try server result with failing platform: (Android 2.3 Emulator try opt test mochitest-4 ) https://tbpl.mozilla.org/?tree=Try&rev=0bc5c4782685 (b2g_emulator_vm try opt test mochitest-3) https://tbpl.mozilla.org/?tree=Try&rev=72b4bd387fe4
Attachment #8466124 -
Flags: review?(roc) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b53034ae4c9
Flags: in-testsuite+
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9b53034ae4c9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•