1047311 - Change the set of colors based on the brightness of the theme-color

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: theme-color.brightness.settings.patch

Settings part.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: theme-color.brightness.patch

System part.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8466116 [details] [diff] [review]
theme-color.brightness.settings.patch

Review of attachment 8466116 [details] [diff] [review]:
-----------------------------------------------------------------

Even with both patches I think the contrast of the text inside the rocketbar is a bit hard to read, but I think this is fine to land for now.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8466117 [details] [diff] [review]
theme-color.brightness.patch

Review of attachment 8466117 [details] [diff] [review]:
-----------------------------------------------------------------

R+, but only if you fix the typo in the className first. Clearing to make sure it's done, but feel free to R+ it after that fix :)

::: apps/system/style/chrome/chrome.css
@@ +235,4 @@
>    background-image: url("images/dark/back.png");
>  }
>  
> +.ligth .controls .forward-button {

Should this be `.light`? Please fix this first.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I fixed the typo and the background-color too dark (I forgot this one as well...).

https://github.com/mozilla-b2g/gaia/commit/1f20f326f317feda0ec59aff011b54a7c62cb9bf