Change the set of colors based on the brightness of the theme-color

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Blocks: 1038738
Created attachment 8466116 [details] [diff] [review]
theme-color.brightness.settings.patch

Settings part.
Attachment #8466116 - Flags: review?(kgrandon)
Created attachment 8466117 [details] [diff] [review]
theme-color.brightness.patch

System part.
Attachment #8466117 - Flags: review?(kgrandon)
Comment on attachment 8466116 [details] [diff] [review]
theme-color.brightness.settings.patch

Review of attachment 8466116 [details] [diff] [review]:
-----------------------------------------------------------------

Even with both patches I think the contrast of the text inside the rocketbar is a bit hard to read, but I think this is fine to land for now.
Attachment #8466116 - Flags: review?(kgrandon) → review+
Comment on attachment 8466117 [details] [diff] [review]
theme-color.brightness.patch

Review of attachment 8466117 [details] [diff] [review]:
-----------------------------------------------------------------

R+, but only if you fix the typo in the className first. Clearing to make sure it's done, but feel free to R+ it after that fix :)

::: apps/system/style/chrome/chrome.css
@@ +235,4 @@
>    background-image: url("images/dark/back.png");
>  }
>  
> +.ligth .controls .forward-button {

Should this be `.light`? Please fix this first.
Attachment #8466117 - Flags: review?(kgrandon)
I fixed the typo and the background-color too dark (I forgot this one as well...).

https://github.com/mozilla-b2g/gaia/commit/1f20f326f317feda0ec59aff011b54a7c62cb9bf
Assignee: nobody → 21
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.