Refactor closeTab() from tabs.js to be similar to the openTab() method

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
5 years ago
3 months ago

People

(Reporter: danisielm, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lib][lang=js], URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 8466114 [details] [diff] [review]
wait-close-tab-animation.patch

We want to update the closeTab() method in our repository to properly wait for the 'TabClose' event.

This may fix some of the problems we have when we want to click on tabs after a current one has been closed.
Attachment #8466114 - Flags: review?(andrei.eftimie)
Attachment #8466114 - Flags: review?(andreea.matei)

Comment 1

5 years ago
Comment on attachment 8466114 [details] [diff] [review]
wait-close-tab-animation.patch

Review of attachment 8466114 [details] [diff] [review]:
-----------------------------------------------------------------

Please do a similar implementation to _waitForTabOpened().
We should also take into account possible transitions.
Attachment #8466114 - Flags: review?(andrei.eftimie)
Attachment #8466114 - Flags: review?(andreea.matei)
Attachment #8466114 - Flags: review-
Assignee: nobody → daniel.gherasim
Status: NEW → ASSIGNED
(Reporter)

Comment 2

4 years ago
As Andrei requested, we need here a new _waitForTabClosed method and also the closeTab will accept a callback method.
Summary: Update closeTab() from tabs.js to wait for the animation event → Refactor closeTab() from tabs.js to be similar to the openTab() method
Assignee: danisielm → nobody
Status: ASSIGNED → NEW
Mozmill is dead, WONTFIX the remaining bugs.
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.