Closed Bug 1047312 Opened 10 years ago Closed 6 years ago

Refactor closeTab() from tabs.js to be similar to the openTab() method

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: danisielm, Unassigned)

References

(
URL
)

Details

(Whiteboard: [lib][lang=js])

Attachments

(1 file)

wait-close-tab-animation.patch
3.63 KB, patch
andrei
: review-
Details | Diff | Splinter Review
We want to update the closeTab() method in our repository to properly wait for the 'TabClose' event. This may fix some of the problems we have when we want to click on tabs after a current one has been closed.
Attachment #8466114 - Flags: review?(andrei.eftimie)
Attachment #8466114 - Flags: review?(andreea.matei)
Comment on attachment 8466114 [details] [diff] [review] wait-close-tab-animation.patch Review of attachment 8466114 [details] [diff] [review]: ----------------------------------------------------------------- Please do a similar implementation to _waitForTabOpened(). We should also take into account possible transitions.
Attachment #8466114 - Flags: review?(andrei.eftimie)
Attachment #8466114 - Flags: review?(andreea.matei)
Attachment #8466114 - Flags: review-
Assignee: nobody → daniel.gherasim
Status: NEW → ASSIGNED
As Andrei requested, we need here a new _waitForTabClosed method and also the closeTab will accept a callback method.
Summary: Update closeTab() from tabs.js to wait for the animation event → Refactor closeTab() from tabs.js to be similar to the openTab() method
Assignee: danisielm → nobody
Status: ASSIGNED → NEW
Mozmill is dead, WONTFIX the remaining bugs.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: