1047389 - Custom position for buttons customized with customize mode is not kept when killing the Firefox process

Status: NEW

(Firefox :: Toolbars and Customization, defect)

Description

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Reproducible with:
Firefox 32 Beta 3 - 20140731191115 - User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Latest Firefox 33 Aurora - 20140731004002
Latest Firefox 34 Nightly - 20140731030206

Environment: Windows 7 x64, Windows XP x86, Windows 8 x64, Ubuntu 13.10 64-bit, Mac OS X 10.6.8

Steps to reproduce:
1. Open Firefox with new profile.
2. Go to http://mixedpuppy.github.io/socialapi-demo/ and choose to activate the Demo Social Service.
3. Choose to enable the service ---> SocialAPI panel displays on the right, with Social Demo icon above.
4. Open the Customization Panel, choose "Customize" and move the Social Demo icon to the right of the Tab strip.
5. Restart Firefox ---> Social Demo icon displays to the right of the Tab strip = OK
6. Open the Customization Panel, choose "Customize" and move the Social Demo icon to the left of the Tab strip.
7. Kill the Firefox process, then open Firefox again.

Expected results: 
The Social Demo icon displays to the left of the Tab strip.

Actual results:
The Social Demo icon displays to the right of the Tab strip. New custom position is not kept when killing the Firefox process.

Notes:
- see "http://www.screencast.com/t/EVLcZ4Zx2n8" 
- the issue seems to almost always reproduce, as I've seen a few cases where it seemed to work (remember the icon position after killing the process)
- I was able to reproduce this in Firefox 29.0.1 as well, so it's no recent regression

Comment 1

[Lawrence Mandel [:lmandel] (use needinfo)]

[Tracking Requested - why for this release]:

Comment 2

[Shane Caraveo (:mixedpuppy)]

This seems more like a customization UI problem than something specific to socialapi.  I'm able to reproduce this with non-socialapi buttons (e.g. move the developer tools button to the toolbar then force crash firefox and restart)

Comment 3

[:Gijs (he/him)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #2)
> This seems more like a customization UI problem than something specific to
> socialapi.  I'm able to reproduce this with non-socialapi buttons (e.g. move
> the developer tools button to the toolbar then force crash firefox and
> restart)

Concur.

We could fix this by manually calling a pref flush. Shudder. Or we could wait for bug 789945.

I don't think this is severe enough to warrant tracking, but I'll leave the flags for more appropriate people to decide. bug 789945 has backlog+, and I don't really want to manually call pref flushes... While we could add one on leaving customize mode, that's got jank written all over it. So I'm going to clear fx-backlog.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This is a longstanding issue in general (pref changes lost when killing Firefox), not something we need to track.