1047391 - nm-symbolicate.py picks up wrong nm binary ("invalid argument -D")

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Markus Stange [:mstange]]

When using "./profile.sh capture" after profiling the b2g Compositor thread, symbolication fails on my Mac and a broken profile is created.

The problem is that nm-symbolicate.py uses the wrong nm binary. On my machine it uses

Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm

when it should be using

/Volumes/firefoxos/B2G/prebuilts/gcc/darwin-x86/arm/arm-linux-androideabi-4.7/bin/arm-linux-androideabi-nm

XCode's nm doesn't support the -D and -S flags that we pass to it and prints the following error message during ./profile.sh capture:

error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: invalid argument -D
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm [-agnopruUmxjlfAP[s segname sectname] [-] [-t format] [[-arch <arch_flag>] ...] [file ...]

Comment 1

[Markus Stange [:mstange]]

Attachment: v1

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 8466186 [details] [diff] [review]
v1

Review of attachment 8466186 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/nm-symbolicate.py
@@ +13,5 @@
>    ]
> +  try:
> +    nm_lines = subprocess.check_output(args).split("\n")
> +  except subprocess.CalledProcessError:
> +    sys.exit(-1)

You should log something instead of silently failing or just let the error bubble up so that it will be echo'ed

Comment 3

[Markus Stange [:mstange]]

OK, I'll just revert the error handling change.

Comment 4

[Markus Stange [:mstange]]

Attachment: v2

Comment 5

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebfcfbeba792

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ebfcfbeba792