1047428 - [AccessFu] Report read only state for editables.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now we are not reporting read only state for things like textarea and text inputs. It is otherwise confusing when the user tries to edit an entry that is not reported as read only so we need to fix that.

Comment 1

[Max Li [:maxli]]

Attachment: Patch

Comment 2

[Eitan Isaacson [:eeejay]]

This looks good. Needs a follow-up bug in gaia.

Comment 3

[Eitan Isaacson [:eeejay]]

I'm a bit concerned that this is going to add too much chatter to random objects that are not immutable form elements. I guess I need to play with this. Max, do you have any insight about when/what objects get readonly?

Comment 4

[Eitan Isaacson [:eeejay]]

What do you think, Marco?

Comment 5

[Marco Zehe (:MarcoZ)]

I think read-only should indeed be restricted to text inputs and text areas, since they are the only ones that can be focusable, but not editable. Other elements are disabled, and thus not focusable, and are already indicated. This needs to be tightly restricted to text fields and text areas, but in those situations, is definitely a good and needed addition.

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8477946 [details] [diff] [review]
Patch

Review of attachment 8477946 [details] [diff] [review]:
-----------------------------------------------------------------

It is early in this gecko cycle, lets give this a try.. If it is too verbose we could figure it out.

Comment 7

[Max Li [:maxli]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a8514301a3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d9a8514301a3