1047443 - slave_failures.html sort for '% failure' not working correctly after changing date

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Dan Minor [:dminor]]

Similar problem to what was fixed in Bug 1030076.

Comment 1

[akruglov]

Please, assign it to me ;)

Comment 2

[Dan Minor [:dminor]]

Thanks for looking at this :)

Comment 3

[akruglov]

Attachment: 0001-Bug-1047443-slave_failures.html-sort-for-failure-not.patch

Oh, I decided to use tablesorter plugin for jQuery instead of sorttable.
Here are docs for it: http://tablesorter.com/docs/index.html

There are some notes:
1. tablesorter supports sorting by multiple columns, however, if you sort table this way and then will fetch data for different days, sorting will be applied, but possible not in the same way. For instance, you sort by total asc and fails desc, but after updating table you'll get fails desc and total asc. I don't see a simply way to restore the right order of sorting.

2. sorting can take some time. it's possible to show some message or overlay while table is resorted, and if it's necessary I can do it. 

3. tables on android failures page don't remember that they were sorted and don't have any default sorting applied. I can change this if it's necessary.

Comment 4

[akruglov]

Attachment: 0001-Bug-1047443-slave_failures.html-sort-for-failure-not.patch

some minor changes (removed unused class names).

Comment 5

[Dan Minor [:dminor]]

Comment on attachment 8466791 [details] [diff] [review]
0001-Bug-1047443-slave_failures.html-sort-for-failure-not.patch

Review of attachment 8466791 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks for your help!

Comment 6

[akruglov]

Sorry, but I took a liberty to examined it after going live, and there is a bug with sorting for slaves page. I gonna fix it today's evening.

Comment 7

[Dan Minor [:dminor]]

Thanks!

Comment 8

[akruglov]

Attachment: 0001-fix-sorting.patch

that should fix sorting.

Comment 9

[Dan Minor [:dminor]]

Comment on attachment 8468069 [details] [diff] [review]
0001-fix-sorting.patch

Review of attachment 8468069 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good in my testing. Thanks!