1047473 - [Messages] Small bottom padding difference when the recipient panel is closed/open

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. open the "new message" panel
2. enter more than 1 line of recipients
3. swipe down the recipient component

=> we see the padding bottom is slightly changing. This does not look right.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Recipient panel is closed

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Recipient panel is open

Comment 3

[Julien Wajsberg [:julienw]]

Hey Fang, can you have a look at these screenshots?

I believe we should have the same padding when the panel is closed/open, and it should be the one that is currently in the "closed" state. What do you think?

Comment 4

[Fang Shih [:fang]]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> Hey Fang, can you have a look at these screenshots?
> 
> I believe we should have the same padding when the panel is closed/open, and
> it should be the one that is currently in the "closed" state. What do you
> think?

Hey Julien, 
Thanks for confirming. I agree with you on this, it should be the "closed" one for both open/closed padding. Thanks!!

Comment 5

[Luke Chang [:lchang] (inactive)]

Hi Julien,

I'd like to take a look at this bug. May I?

Comment 6

[Julien Wajsberg [:julienw]]

Of course, I'd be glad :)
Thanks !

Comment 7

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 22654

Hi Steve,

Would you mind helping to review this simple patch? Thanks.

Comment 8

[Luke Chang [:lchang] (inactive)]

Attachment: Recipient panel is closed (patched)

Comment 9

[Luke Chang [:lchang] (inactive)]

Attachment: Recipient panel is open (patched)

Comment 10

[Steve Chung [:steveck]]

(In reply to Luke Chang [:lchang] from comment #7)
> Created attachment 8469787 [details] [review]
> Pull Request 22654
> 
> Hi Steve,
> 
> Would you mind helping to review this simple patch? Thanks.

Comment on github, please also adjust the max-height as well, thanks!

Comment 11

[Luke Chang [:lchang] (inactive)]

Hi Steve,

I've changed my patch and addressed the comment. Please check again. Thanks a lot.

Comment 12

[Steve Chung [:steveck]]

Comment on attachment 8469787 [details] [review]
Pull Request 22654

This fixing looks good to me, thanks!

Comment 13

[Luke Chang [:lchang] (inactive)]

master: https://github.com/mozilla-b2g/gaia/commit/1bed5ea71ddca38a18f447cef0f44104d5028f5b

Steve, Thanks for review!