Closed Bug 1047495 Opened 5 years ago Closed 5 years ago

Push both a JS and a CPP frame for js:RunScript

Categories

(Core :: Gecko Profiler, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(1 file)

The profiler relies on a CPP frame to combine JS stack with native stack.

The hang monitor relies on a JS frame to record the script name and line number of a hang.
Bug 1040390 changed js::RunScript from a JS frame to a CPP frame, but the hang monitor requires a JS frame in order to detect hangs that happen when running scripts. I guess what we need is both a CPP frame and a JS frame.
Attachment #8466400 - Flags: review?(kvijayan)
Comment on attachment 8466400 [details] [diff] [review]
Push RunScript JS frame in addition to CPP frame (v1)

Review of attachment 8466400 [details] [diff] [review]:
-----------------------------------------------------------------

A bit odd, but seems to be a reasonable solution.
Attachment #8466400 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/e2dc50b68014
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.