Push both a JS and a CPP frame for js:RunScript

RESOLVED FIXED in mozilla34

Status

()

Core
Gecko Profiler
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The profiler relies on a CPP frame to combine JS stack with native stack.

The hang monitor relies on a JS frame to record the script name and line number of a hang.
(Assignee)

Comment 1

4 years ago
Created attachment 8466400 [details] [diff] [review]
Push RunScript JS frame in addition to CPP frame (v1)

Bug 1040390 changed js::RunScript from a JS frame to a CPP frame, but the hang monitor requires a JS frame in order to detect hangs that happen when running scripts. I guess what we need is both a CPP frame and a JS frame.
Attachment #8466400 - Flags: review?(kvijayan)
Comment on attachment 8466400 [details] [diff] [review]
Push RunScript JS frame in addition to CPP frame (v1)

Review of attachment 8466400 [details] [diff] [review]:
-----------------------------------------------------------------

A bit odd, but seems to be a reasonable solution.
Attachment #8466400 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2dc50b68014
Assignee: nobody → nchen
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/e2dc50b68014
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.