1047495 - Push both a JS and a CPP frame for js:RunScript

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

The profiler relies on a CPP frame to combine JS stack with native stack.

The hang monitor relies on a JS frame to record the script name and line number of a hang.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Push RunScript JS frame in addition to CPP frame (v1)

Bug 1040390 changed js::RunScript from a JS frame to a CPP frame, but the hang monitor requires a JS frame in order to detect hangs that happen when running scripts. I guess what we need is both a CPP frame and a JS frame.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 8466400 [details] [diff] [review]
Push RunScript JS frame in addition to CPP frame (v1)

Review of attachment 8466400 [details] [diff] [review]:
-----------------------------------------------------------------

A bit odd, but seems to be a reasonable solution.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2dc50b68014

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2dc50b68014