1047643 - "Vertical tabs" add-on displays tabs as pinned tabs instead of sidebar tabs

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[juan becerra [:juanb]]

Attachment: VerticalTabs.png

Vertical Tabs doesn't seem to work with e10s using latest Nightly (Fx34).

Steps:
1. Using Nightly on Windows 8.1 in e10s mode, open several tabs.
2. Download: https://addons.mozilla.org/en-US/firefox/addon/vertical-tabs/

Expected: Tabs are listed in the sidebar properly.

Actual: The tabs look like a strip of pinned tabs. See attached image.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Ally and I tested this one in a non-e10s Firefox Aurora build and it seems to be broken there too.

Comment 2

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

This was a regression in Nightly 32 build 2014-05-03, unrelated to e10s. I bisected mozilla-inbound to this regression pushlog:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f8497c9757f1&tochange=43c5be10eae0

The regression was probably changeset 6a927b1634f6 ("Merge fx-team to m-c"), which is not very helpful:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a927b1634f6

Comment 3

[Alice0775 White]

Error in error console:

undefined entity vertical-tabbrowser.xml:67

And triggered by
4dc06a48ed13	Mike de Boer — Bug 979479: add dynamic tooltips, including keyboard shortcuts, to various buttons. r=mconley

The add-on author should modify their code.

Comment 4

[Chris Peterson [:cpeterson]]

philikon, vladv: are you still maintaining the Vertical Tabs add-on? It was broken in Firefox Beta 32 by bug 979479.

https://github.com/philikon/VerticalTabs/issues/36
https://github.com/philikon/VerticalTabs/issues/37

Comment 5

[Gabor Krizsanits (INACTIVE)]

Assignee: Gabor Krizsanits
Link to add-on: https://addons.mozilla.org/firefox/downloads/file/248776/vertical_tabs-0.10b1-fx.xpi?src=dp-btn-primary
Contact info for add-on: Author seems to abandoned the add-on
Add-on ID: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
How well does it work?: It's dead. The UI is badly broken with the add-on installed. There are some github forks, but even those seem to be dead by now.
Steps to reproduce working features:
Steps to reproduce broken features: Tabs should be vertically arranged on the left sidebar. Now they are horizontally arranged so they don't fit in the sidebar and there are some other GUI glitches it cases on the browser GUI. This happens in non e10s mode.
Any obvious performance problems? no
Chromium version: no, in fact Google gave up on making this possible

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I've actually been using this version of the add-on for a while and it works very well:
https://github.com/darrinhenein/VerticalTabs

Comment 7

[Gabor Krizsanits (INACTIVE)]

(In reply to Bill McCloskey (:billm) from comment #6)
> I've actually been using this version of the add-on for a while and it works
> very well:
> https://github.com/darrinhenein/VerticalTabs

Thanks, I gave it a second try it, using your link and that version does seem to work flawlessly indeed.

Comment 8

[Graham Perrin]

(In reply to juan becerra [:juanb] from comment #0)

> … 
> 
> Expected: Tabs are listed in the sidebar properly.
> 
> Actual: The tabs look like a strip of pinned tabs. See attached image.

Not an issue with 
Vertical Tabs Reloaded 0.8.4-alpha 
<https://addons.mozilla.org/firefox/addon/vertical-tabs-reloaded/> 
on Firefox 54.0.1 (64-bit) on FreeBSD-CURRENT.

Comment 9

[Andy McKay]

This is about a legacy extension which is no longer valid in Firefox Quantum, closing.