1047648 - TelemetryImpl::mHistogramMap can use nsDepCharHashKey

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Andrew McCreight [:mccr8]]

In bug 1047523, froydnj pointed out that mHistogramMap doesn't outlive the string keys it uses, so it can use nsDepCharHashKey.  On OSX desktop, on a newly-opened browser, this saves 38kb of memory.

I'm not sure how telemetry works on B2G, but if it is there, it might be worth backporting some places, as it is super simple.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: TelemetryImpl::mHistogramMap can use nsDepCharHashKey.

Comment 2

[Andrew McCreight [:mccr8]]

try run: https://tbpl.mozilla.org/?tree=Try&rev=c2d7bf52d31d

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ff2c61b9e41

Comment 3

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/0ff2c61b9e41