If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

TelemetryImpl::mHistogramMap can use nsDepCharHashKey

RESOLVED FIXED in mozilla34

Status

()

Toolkit
Telemetry
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P3])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In bug 1047523, froydnj pointed out that mHistogramMap doesn't outlive the string keys it uses, so it can use nsDepCharHashKey.  On OSX desktop, on a newly-opened browser, this saves 38kb of memory.

I'm not sure how telemetry works on B2G, but if it is there, it might be worth backporting some places, as it is super simple.
(Assignee)

Comment 1

3 years ago
Created attachment 8466534 [details] [diff] [review]
TelemetryImpl::mHistogramMap can use nsDepCharHashKey.
Attachment #8466534 - Flags: review?(aklotz)
Attachment #8466534 - Flags: review?(aklotz) → review+
Whiteboard: [MemShrink] → [MemShrink:P3]
(Assignee)

Comment 2

3 years ago
try run: https://tbpl.mozilla.org/?tree=Try&rev=c2d7bf52d31d

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ff2c61b9e41

Comment 3

3 years ago
https://hg.mozilla.org/mozilla-central/rev/0ff2c61b9e41
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.