Closed
Bug 1047662
Opened 11 years ago
Closed 11 years ago
Typo on webmaker.org/signup
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Webmaker Graveyard
webmaker.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: akirose, Assigned: akshaytiwari.003, Mentored)
References
()
Details
(Whiteboard: [goodfirstbug])
Attachments
(1 file)
“Use Webmaker-vetted teaching resources and tempaltes” should read “Use Webmaker-vetted teaching resources and templates”
| Assignee | ||
Comment 1•11 years ago
|
||
I'm working on this work.
| Assignee | ||
Comment 2•11 years ago
|
||
I resolved the bug and even pulled a request. The pull request is given below.
https://github.com/mozilla/webmaker.org/pull/924
Flags: needinfo?(akshaytiwari.003)
| Reporter | ||
Comment 3•11 years ago
|
||
Great, thanks so much! The next step is to add an “attachment” with your pull request.
1. Click "add an attachment"
2. Click "paste text as attachment"
3. Paste a link to your pull request in the "file" and "description" fields
4. In flags, change "Review" to "?" and find me (:akirose)
5. Click "Submit" !
Assignee: nobody → akshaytiwari.003
Status: NEW → ASSIGNED
Flags: needinfo?(akshaytiwari.003)
| Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8467770 -
Flags: review?(aki)
| Reporter | ||
Updated•11 years ago
|
Attachment #8467770 -
Flags: review?(aki) → review+
Comment 5•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/b5731d8168e98510f61680c3756bfa81f9fd1ef0
Merge pull request #924 from AkshayTiwari/patch-1
Fixes Bug 1047662 - Typo on webmaker.org/signup
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
I think this typo is still showing up here: https://webmaker.org/signup?src=welcomelearners
Two people have mentioned it on Twitter today.
Flags: needinfo?(aki)
| Assignee | ||
Comment 7•11 years ago
|
||
I resolved it and attached the file too. Even i saw it today. I assumed they may fix a group of bugs together and deploy it.
I don't know.
Aki Rose, Can you tell us why is this happening ?
| Reporter | ||
Comment 8•11 years ago
|
||
Sorry, I wasn't able to deploy that right away. It's up now.
Flags: needinfo?(aki)
You need to log in
before you can comment on or make changes to this bug.
Description
•