104768 - Mozilla launch script assumes bash version 2.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Oliver Jones]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.5) Gecko/20011012
BuildID:    2001101201

The Mozilla launch script assumes the OS has Bash V2 installed.

On RedHat Linux 6.2 /bin/sh is bash 1.14.7(1) and /bin/bash2 is
2.03.8(1)-release.  The "test" (aka [] operator) syntax is different between
these versions as can be seen in the following console dump:

[oliver] singularity:~$ mozilla 
/usr/bin/mozilla: [: ==: binary operator expected
[oliver] singularity:~$ bash2 mozilla 
(no output)

I believe the lines in question are: 

if [ "${ALREADY_RUNNING}" == "1" ] && [ -z "$1" ]; then
  exec $MOZ_PROGRAM -remote "xfeDoCommand(openBrowser)" 2>/dev/null >/dev/null
fi

A backwards compatible version of this would be:
if [ "${ALREADY_RUNNING}" -eq "1" ] && [ -z "$1" ]; then...

This type of syntax is used elsewhere in the script.



Reproducible: Always
Steps to Reproduce:
1. Run the mozilla script with bash 1
2. Run the mozilla script with bash 2


Actual Results:  An error in the shell script.

Expected Results:  No errors in the shell script.

This problem doesn't appear to effect the operation of Moz too much but would
certainly make successive calls to mozilla open faster when there is already a
running instance.

Here is a patch:

--- mozilla.orig	Mon Oct 15 17:52:25 2001
+++ mozilla	Mon Oct 15 17:52:38 2001
@@ -156,7 +156,7 @@
 
 # If there is no command line argument at all then try to open a new
 # window in an already running instance.
-if [ "${ALREADY_RUNNING}" == "1" ] && [ -z "$1" ]; then
+if [ "${ALREADY_RUNNING}" -eq "1" ] && [ -z "$1" ]; then
   exec $MOZ_PROGRAM -remote "xfeDoCommand(openBrowser)" 2>/dev/null >/dev/null
 fi

Comment 1

[Asa Dotzler [:asa]]

->build config.

Comment 2

[hacker formerly known as [e-mail]]

/usr/bin/mozilla ? Must be from an rpm install. The xpfe/bootstrap/mozilla
script does not have this error. -> blizzard

Comment 3

[Oliver Jones]

It is from an rpm install.  

Comment 4

[Christopher Blizzard (:blizzard)]

Thanks!  Checked in.

Comment 5

[Christopher Blizzard (:blizzard)]

*** Bug 106248 has been marked as a duplicate of this bug. ***