Closed
Bug 1047715
Opened 10 years ago
Closed 10 years ago
suite's in-tree mozconfigs need changing to support Mock
Categories
(SeaMonkey :: Release Engineering, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ewong, Assigned: ewong)
References
Details
Attachments
(1 file, 3 obsolete files)
8.54 KB,
patch
|
Callek
:
review+
Callek
:
approval-comm-aurora+
Callek
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Currently, we use /tools/gcc-4.5/bin/g*. Mock uses /tools/gcc-4.73-0moz1/g*. Need to fix this before we can continue with bug 840427.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8466546 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 2•10 years ago
|
||
Note: This for a post-push review.
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Edmund Wong (:ewong) from comment #2) > Note: This for a post-push review. And it will need to be pushed to c-a, c-b and c-r. (Currently working on c-c.)
Assignee | ||
Comment 4•10 years ago
|
||
Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/ed06f56783b2
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8466546 [details] [diff] [review] bug_1047715.diff [Approval Request Comment] Regression caused by (bug #): User impact if declined: Mock requires these changes to build. Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): None String changes made by this patch: None.
Attachment #8466546 -
Flags: approval-comm-release?
Attachment #8466546 -
Flags: approval-comm-beta?
Attachment #8466546 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 6•10 years ago
|
||
Backed out the patch. https://hg.mozilla.org/comm-central/rev/328d90cafea0 Reason: Wrong gcc version.
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8466546 -
Attachment is obsolete: true
Attachment #8466546 -
Flags: review?(bugspam.Callek)
Attachment #8466546 -
Flags: approval-comm-release?
Attachment #8466546 -
Flags: approval-comm-beta?
Attachment #8466546 -
Flags: approval-comm-aurora?
Attachment #8466558 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 8•10 years ago
|
||
Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/f9940e7c5614
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8466558 [details] [diff] [review] suite mozconfig changes to support Mock (v2) [Approval Request Comment] Regression caused by (bug #): User impact if declined: need this patch to build aurora and beta Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch: None
Attachment #8466558 -
Flags: approval-comm-beta?
Attachment #8466558 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 10•10 years ago
|
||
Got Callek's approval (over irc). Pushed to comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/9ba16c7b3e4b
Assignee | ||
Comment 11•10 years ago
|
||
Pushed to comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/e5b278cbe398
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8466558 [details] [diff] [review] suite mozconfig changes to support Mock (v2) [Approval Request Comment] Regression caused by (bug #): User impact if declined: needs this patch to build c-r Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch:
Attachment #8466558 -
Flags: approval-comm-release?
Assignee | ||
Updated•10 years ago
|
Attachment #8466558 -
Attachment is obsolete: true
Attachment #8466558 -
Flags: review?(bugspam.Callek)
Attachment #8466558 -
Flags: approval-comm-release?
Attachment #8466558 -
Flags: approval-comm-beta?
Attachment #8466558 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 13•10 years ago
|
||
This patch was taken from bug 1047999. It fixes the build problems as it was pushed to c-b. Now afaik, it should be pushed to c-c, c-a and c-r.
Attachment #8471219 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8471219 [details] [diff] [review] suite patch (v4) [Approval Request Comment] Regression caused by (bug #): User impact if declined: needs these patches to build. Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch:
Attachment #8471219 -
Flags: approval-comm-release?
Attachment #8471219 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 15•10 years ago
|
||
Landing for post-landing review/approval to c-a, c-r and c-c a=Callek over irc.
Assignee | ||
Comment 16•10 years ago
|
||
Pushed to comm-release: https://hg.mozilla.org/releases/comm-release/rev/410b041f4841
Assignee | ||
Comment 17•10 years ago
|
||
Updated bitrotted patch for c-c, c-a. Going for post-landing review/approval. (a=Callek over irc) [Approval Request Comment] Regression caused by (bug #): User impact if declined: needs this to build on infra. Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch:
Attachment #8471331 -
Flags: review?
Attachment #8471331 -
Flags: approval-comm-release?
Attachment #8471331 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 18•10 years ago
|
||
Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/f9e88f13f801
Assignee | ||
Updated•10 years ago
|
Attachment #8471219 -
Attachment is obsolete: true
Attachment #8471219 -
Flags: review?(bugspam.Callek)
Attachment #8471219 -
Flags: approval-comm-release?
Attachment #8471219 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 19•10 years ago
|
||
Pushed to comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/be5fafd6c64f
Attachment #8471331 -
Flags: review? → review?(bugspam.Callek)
Comment 20•10 years ago
|
||
Comment on attachment 8471331 [details] [diff] [review] patch (v5) Review of attachment 8471331 [details] [diff] [review]: ----------------------------------------------------------------- r+ and post-land a+
Attachment #8471331 -
Flags: review?(bugspam.Callek)
Attachment #8471331 -
Flags: review+
Attachment #8471331 -
Flags: approval-comm-release?
Attachment #8471331 -
Flags: approval-comm-release+
Attachment #8471331 -
Flags: approval-comm-aurora?
Attachment #8471331 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 21•10 years ago
|
||
Marking this is as fixed since all trees have been patched.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•