1047783 - Make sure error don't get ignored in the stateManager promise chain

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1043828 +++

Please read comment 11 of the cloned bug. StateManager does not catch and output the error in the promise chain, making things hard to debug.

The patch here does not fix the problem in comment 11, not the cloned bug. We still need a graceful handling of "external" errors (wrap in try ... catch, maybe).

Comment 1

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#22445

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8466623 [details] [review]
mozilla-b2g:master PR#22445

We shouldn't ignore any error, but we do want to ignore Promise.reject(); without anything passed to us, since it's considered normal handling (in layoutManager and inputMethodManager).

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8466623 [details] [review]
mozilla-b2g:master PR#22445

r+, but as discussed offline, please make sure that the failing Gij passes its re-run before merging, thanks!

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/3a97d28c2da58447a7d656f11a69bf055e54d8c4

Gij finally passes: https://tbpl.mozilla.org/?rev=9c3af45a2a126c592116868343f8dd949276a807&tree=Gaia-Try