Ignore mousemove event if mouse button is not pressed

RESOLVED FIXED in 2.1 S2 (15aug)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

unspecified
2.1 S2 (15aug)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

There is a logic error in UserPressManager where it will attempt to process mousemove event even if the mouse button is not pressed. 

STR:

1. Try to run Gaia Keyboard on desktop Firefox w/ mouse events. (I have a yet-to-released tool to do so)
2. Click on a key (press-release the mouse button)
3. Move the mouse cursor over keyboard

Expected:

1. Nothing

Actual:

1. Nothing, but console prints JS Error.

Mouse event is only relevant on desktop, but it's still worthy to fix in Gaia codebase IMHO.
Attachment #8466851 - Flags: review?(rlu)
Comment on attachment 8466851 [details] [review]
mozilla-b2g:master PR#22459

r=me.
Thanks.
Attachment #8466851 - Flags: review?(rlu) → review+
You need to log in before you can comment on or make changes to this bug.