If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Ignore mousemove event if mouse button is not pressed

RESOLVED FIXED in 2.1 S2 (15aug)

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

unspecified
2.1 S2 (15aug)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

There is a logic error in UserPressManager where it will attempt to process mousemove event even if the mouse button is not pressed. 

STR:

1. Try to run Gaia Keyboard on desktop Firefox w/ mouse events. (I have a yet-to-released tool to do so)
2. Click on a key (press-release the mouse button)
3. Move the mouse cursor over keyboard

Expected:

1. Nothing

Actual:

1. Nothing, but console prints JS Error.

Mouse event is only relevant on desktop, but it's still worthy to fix in Gaia codebase IMHO.
Created attachment 8466851 [details] [review]
mozilla-b2g:master PR#22459
Attachment #8466851 - Flags: review?(rlu)
Comment on attachment 8466851 [details] [review]
mozilla-b2g:master PR#22459

r=me.
Thanks.
Attachment #8466851 - Flags: review?(rlu) → review+
master: https://github.com/mozilla-b2g/gaia/commit/cb4cd5e122fb1a5d313198515b89c2380cf205ef

https://tbpl.mozilla.org/?rev=e6d46392efdaf867a6b8fd87ec4097c06b89ed17&tree=Gaia-Try
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.