1047976 - Ignore mousemove event if mouse button is not pressed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

There is a logic error in UserPressManager where it will attempt to process mousemove event even if the mouse button is not pressed. 

STR:

1. Try to run Gaia Keyboard on desktop Firefox w/ mouse events. (I have a yet-to-released tool to do so)
2. Click on a key (press-release the mouse button)
3. Move the mouse cursor over keyboard

Expected:

1. Nothing

Actual:

1. Nothing, but console prints JS Error.

Mouse event is only relevant on desktop, but it's still worthy to fix in Gaia codebase IMHO.

Comment 1

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#22459

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8466851 [details] [review]
mozilla-b2g:master PR#22459

r=me.
Thanks.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/cb4cd5e122fb1a5d313198515b89c2380cf205ef

https://tbpl.mozilla.org/?rev=e6d46392efdaf867a6b8fd87ec4097c06b89ed17&tree=Gaia-Try