Closed Bug 1047981 Opened 5 years ago Closed 5 years ago

Port |Bug 1047924 - When building with ac_add_options --enable-extensions extensions are put expanded into the wrong location in dist/bin| to comm-central

Categories

(MailNews Core :: Build Config, defect, critical)

defect
Not set
critical

Tracking

(thunderbird34 fixed)

RESOLVED FIXED
Thunderbird 34.0
Tracking Status
thunderbird34 --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Depends on 1 open bug)

Details

(Keywords: dogfood, regression)

Attachments

(1 file)

In the old build system extensions would be expanded under dist/bin/distribution/extensions but they currently being put under dist/bin/extensions
This means that when a new user starts the application they do not have the extensions and they do not show up under Extensions in the Add-ons Manager.
The code that does the expansion starts at:
http://mxr.mozilla.org/comm-central/source/config/rules.mk#1375
xref bug 1040009 (in case it's relevant)
Status: NEW → ASSIGNED
No longer blocks: 1044460
Depends on: 1044460
Attachment #8468665 - Flags: review?(Pidgeot18)
Depends on: 1047924
Blocks: 1049800
See bug 1047924 comment#4 for why I don't understand this change.
Attachment #8468665 - Flags: review?(Pidgeot18) → review+
Depends on: 1051642
Blocks: 1050992
Comment on attachment 8468665 [details] [diff] [review]
Port extension changes to c-c [Checked in: Comment 6]

Review of attachment 8468665 [details] [diff] [review]:
-----------------------------------------------------------------

did this land?
(In reply to Justin Wood (:Callek) from comment #4)
> Comment on attachment 8468665 [details] [diff] [review]
> Port extension changes to c-c
> 
> Review of attachment 8468665 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> did this land?

No, it didn't.
http://hg.mozilla.org/comm-central/file/c90567e2d29c/config/rules.mk#l1375
Comment on attachment 8468665 [details] [diff] [review]
Port extension changes to c-c [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/688c69340bbe
Attachment #8468665 - Attachment description: Port extension changes to c-c → Port extension changes to c-c [Checked in: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
You need to log in before you can comment on or make changes to this bug.