If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Port |Bug 1047924 - When building with ac_add_options --enable-extensions extensions are put expanded into the wrong location in dist/bin| to comm-central

RESOLVED FIXED in Thunderbird 34.0

Status

MailNews Core
Build Config
--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

(Depends on: 1 bug, {dogfood, regression})

Trunk
Thunderbird 34.0
dogfood, regression
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird34 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In the old build system extensions would be expanded under dist/bin/distribution/extensions but they currently being put under dist/bin/extensions
This means that when a new user starts the application they do not have the extensions and they do not show up under Extensions in the Add-ons Manager.
The code that does the expansion starts at:
http://mxr.mozilla.org/comm-central/source/config/rules.mk#1375

Comment 1

3 years ago
xref bug 1040009 (in case it's relevant)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
No longer blocks: 1044460
Depends on: 1044460
(Assignee)

Comment 2

3 years ago
Created attachment 8468665 [details] [diff] [review]
Port extension changes to c-c [Checked in: Comment 6]
Attachment #8468665 - Flags: review?(Pidgeot18)
(Assignee)

Updated

3 years ago
Depends on: 1047924
(Assignee)

Updated

3 years ago
Blocks: 1049800

Comment 3

3 years ago
See bug 1047924 comment#4 for why I don't understand this change.
Attachment #8468665 - Flags: review?(Pidgeot18) → review+
(Assignee)

Updated

3 years ago
Depends on: 1051642

Updated

3 years ago
Blocks: 1050992
Comment on attachment 8468665 [details] [diff] [review]
Port extension changes to c-c [Checked in: Comment 6]

Review of attachment 8468665 [details] [diff] [review]:
-----------------------------------------------------------------

did this land?

Comment 5

3 years ago
(In reply to Justin Wood (:Callek) from comment #4)
> Comment on attachment 8468665 [details] [diff] [review]
> Port extension changes to c-c
> 
> Review of attachment 8468665 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> did this land?

No, it didn't.
http://hg.mozilla.org/comm-central/file/c90567e2d29c/config/rules.mk#l1375
(Assignee)

Comment 6

3 years ago
Comment on attachment 8468665 [details] [diff] [review]
Port extension changes to c-c [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/688c69340bbe
Attachment #8468665 - Attachment description: Port extension changes to c-c → Port extension changes to c-c [Checked in: Comment 6]
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
status-thunderbird34: --- → fixed
You need to log in before you can comment on or make changes to this bug.