1047998 - [dialer] Long number is not showed properly (first digits is out of screen)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Raniere Silva]

Attachment: screenshot demonstrating the bug

Steps to reproduce:

1. Launch the dialer
2. Type an long number (at least 12 digits)
	 
Actual Results:

The first digits aren't showed or are truncated (see attachment).
	 
Expected Results:

Change the font size of the numbers (this was the previous behavior) or break the number into two lines.

Additional information:

- Gaia:
  commit 445cd4844a35213da74057f4629ee269a29229a0
  Date:   Sat Aug 2 14:20:40 2014 +0200

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Hi,

Mind if I take this bug?

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: Pull request

Hi Rik,

Would you mind reviewing my patch? :)

Thanks

Comment 3

[Anthony Ricaud (:rik)]

This is a regression of bug 967440.

Comment 4

[Anthony Ricaud (:rik)]

Comment on attachment 8469788 [details] [review]
Pull request

That was a stupid error on my part, thanks for finding this.

I'm marking it as feedback+ only because we need new tests. Since you wrote some new tests in bug 1047275, do you mind writing one for this patch? I'll write it if you can. Thanks!

Comment 5

[Anthony Ricaud (:rik)]

correction: I'll write it if you can't.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Sure, I'll write new tests for it.

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8469788 [details] [review]
Pull request

New tests added.

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 8469788 [details] [review]
Pull request

Excellent! Thanks a lot.

Comment 10

[Tzu-Lin Huang [:dwi2][:tzhuang]]

landed on gaia master
https://github.com/mozilla-b2g/gaia/commit/532fcb917fb67106abbe1046a5fffed416408404