Closed Bug 1047999 Opened 5 years ago Closed 5 years ago

/media/mtransport/runnable_utils_generated.h:103:5: error: invalid conversion from ‘int’ to ‘mozilla::VideoSessionConduit*’

Categories

(SeaMonkey :: Build Config, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(2 files, 1 obsolete file)

C-C (specifically SeaMonkey build on Linux64) is failing in the compile
process with the following:

TestUpload
/builds/slave/c-cen-t-lnx/build/objdir/mozilla/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/expandlibs_exec.py --uselist --  /usr/bin/ccache /tools/gcc-4.5-0moz3/bin/g++  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fno-omit-frame-pointer   -o TestUpload TestUpload.o  -lpthread  -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id    -Wl,-rpath-link,/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/bin -Wl,-rpath-link,/usr/local/lib   -Wl,--whole-archive /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmozglue.a /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmemory.a -Wl,--no-whole-archive -rdynamic ../../xpcom/glue/libxpcomglue_s.a ../../build/unix/stdc++compat/libstdc++compat.a ../../memory/mozalloc/libmozalloc.so ../../toolkit/library/libxul.so -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4  -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4 -ldl   
TestURLParser
/builds/slave/c-cen-t-lnx/build/objdir/mozilla/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/expandlibs_exec.py --uselist --  /usr/bin/ccache /tools/gcc-4.5-0moz3/bin/g++  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fno-omit-frame-pointer   -o TestURLParser TestURLParser.o  -lpthread  -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id    -Wl,-rpath-link,/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/bin -Wl,-rpath-link,/usr/local/lib   -Wl,--whole-archive /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmozglue.a /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmemory.a -Wl,--no-whole-archive -rdynamic ../../xpcom/glue/libxpcomglue_s.a ../../build/unix/stdc++compat/libstdc++compat.a ../../memory/mozalloc/libmozalloc.so ../../toolkit/library/libxul.so -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4  -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4 -ldl   
urltest
/builds/slave/c-cen-t-lnx/build/objdir/mozilla/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/expandlibs_exec.py --uselist --  /usr/bin/ccache /tools/gcc-4.5-0moz3/bin/g++  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fno-omit-frame-pointer   -o urltest urltest.o  -lpthread  -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id    -Wl,-rpath-link,/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/bin -Wl,-rpath-link,/usr/local/lib   -Wl,--whole-archive /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmozglue.a /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmemory.a -Wl,--no-whole-archive -rdynamic ../../xpcom/glue/libxpcomglue_s.a ../../build/unix/stdc++compat/libstdc++compat.a ../../memory/mozalloc/libmozalloc.so ../../toolkit/library/libxul.so -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4  -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4 -ldl   
TestCookie
/builds/slave/c-cen-t-lnx/build/objdir/mozilla/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/expandlibs_exec.py --uselist --  /usr/bin/ccache /tools/gcc-4.5-0moz3/bin/g++  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fno-omit-frame-pointer   -o TestCookie TestCookie.o  -lpthread  -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id    -Wl,-rpath-link,/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/bin -Wl,-rpath-link,/usr/local/lib   -Wl,--whole-archive /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmozglue.a /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmemory.a -Wl,--no-whole-archive -rdynamic ../../xpcom/glue/libxpcomglue_s.a ../../build/unix/stdc++compat/libstdc++compat.a ../../memory/mozalloc/libmozalloc.so ../../toolkit/library/libxul.so -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4  -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4 -ldl   
TestSTSParser
/builds/slave/c-cen-t-lnx/build/objdir/mozilla/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/expandlibs_exec.py --uselist --  /usr/bin/ccache /tools/gcc-4.5-0moz3/bin/g++  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fno-omit-frame-pointer   -o TestSTSParser TestSTSParser.o  -lpthread  -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id    -Wl,-rpath-link,/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/bin -Wl,-rpath-link,/usr/local/lib   -Wl,--whole-archive /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmozglue.a /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmemory.a -Wl,--no-whole-archive -rdynamic ../../xpcom/glue/libxpcomglue_s.a ../../build/unix/stdc++compat/libstdc++compat.a ../../memory/mozalloc/libmozalloc.so ../../toolkit/library/libxul.so -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4  -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4 -ldl   
TestUDPSocket
/builds/slave/c-cen-t-lnx/build/objdir/mozilla/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/expandlibs_exec.py --uselist --  /usr/bin/ccache /tools/gcc-4.5-0moz3/bin/g++  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fno-omit-frame-pointer   -o TestUDPSocket TestUDPSocket.o  -lpthread  -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id    -Wl,-rpath-link,/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/bin -Wl,-rpath-link,/usr/local/lib   -Wl,--whole-archive /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmozglue.a /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib/libmemory.a -Wl,--no-whole-archive -rdynamic ../../xpcom/glue/libxpcomglue_s.a ../../build/unix/stdc++compat/libstdc++compat.a ../../memory/mozalloc/libmozalloc.so ../../toolkit/library/libxul.so -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4  -L/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/lib -lnspr4 -lplc4 -lplds4 -ldl   
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp: In member function ‘void<unnamed>::TransportConduitTest::TestDummyAudioAndTransport()’:
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:532:63: warning: passing NULL to non-pointer argument 2 of ‘mozilla::runnable_args_nm_1_ret<M, A0, R>* mozilla::WrapRunnableNMRet(M, A0, R*) [with M = mozilla::RefPtr<mozilla::AudioSessionConduit> (*)(mozilla::AudioSessionConduit*), A0 = int, R = mozilla::RefPtr<mozilla::AudioSessionConduit>]’
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:540:64: warning: passing NULL to non-pointer argument 2 of ‘mozilla::runnable_args_nm_1_ret<M, A0, R>* mozilla::WrapRunnableNMRet(M, A0, R*) [with M = mozilla::RefPtr<mozilla::AudioSessionConduit> (*)(mozilla::AudioSessionConduit*), A0 = int, R = mozilla::RefPtr<mozilla::AudioSessionConduit>]’
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp: In member function ‘void<unnamed>::TransportConduitTest::TestDummyVideoAndTransport(bool, const char*)’:
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:598:63: warning: passing NULL to non-pointer argument 2 of ‘mozilla::runnable_args_nm_1_ret<M, A0, R>* mozilla::WrapRunnableNMRet(M, A0, R*) [with M = mozilla::RefPtr<mozilla::VideoSessionConduit> (*)(mozilla::VideoSessionConduit*), A0 = int, R = mozilla::RefPtr<mozilla::VideoSessionConduit>]’
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:607:64: warning: passing NULL to non-pointer argument 2 of ‘mozilla::runnable_args_nm_1_ret<M, A0, R>* mozilla::WrapRunnableNMRet(M, A0, R*) [with M = mozilla::RefPtr<mozilla::VideoSessionConduit> (*)(mozilla::VideoSessionConduit*), A0 = int, R = mozilla::RefPtr<mozilla::VideoSessionConduit>]’
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp: In member function ‘void<unnamed>::TransportConduitTest::TestVideoConduitCodecAPI()’:
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:698:62: warning: passing NULL to non-pointer argument 2 of ‘mozilla::runnable_args_nm_1_ret<M, A0, R>* mozilla::WrapRunnableNMRet(M, A0, R*) [with M = mozilla::RefPtr<mozilla::VideoSessionConduit> (*)(mozilla::VideoSessionConduit*), A0 = int, R = mozilla::RefPtr<mozilla::VideoSessionConduit>]’
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp: In member function ‘void<unnamed>::TransportConduitTest::GetVideoResolutionWithMaxFs(int, int, int, int*, int*)’:
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:810:63: warning: passing NULL to non-pointer argument 2 of ‘mozilla::runnable_args_nm_1_ret<M, A0, R>* mozilla::WrapRunnableNMRet(M, A0, R*) [with M = mozilla::RefPtr<mozilla::VideoSessionConduit> (*)(mozilla::VideoSessionConduit*), A0 = int, R = mozilla::RefPtr<mozilla::VideoSessionConduit>]’
In file included from ../../../../../../mozilla/media/mtransport/runnable_utils.h:70:0,
                 from ../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:21:
../../../../../../mozilla/media/mtransport/runnable_utils_generated.h: In member function ‘nsresult mozilla::runnable_args_nm_1_ret<M, A0, R>::Run() [with M = mozilla::RefPtr<mozilla::VideoSessionConduit> (*)(mozilla::VideoSessionConduit*), A0 = int, R = mozilla::RefPtr<mozilla::VideoSessionConduit>, nsresult = unsigned int]’:
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:1060:1:   instantiated from here
../../../../../../mozilla/media/mtransport/runnable_utils_generated.h:103:5: error: invalid conversion from ‘int’ to ‘mozilla::VideoSessionConduit*’
../../../../../../mozilla/media/mtransport/runnable_utils_generated.h: In member function ‘nsresult mozilla::runnable_args_nm_1_ret<M, A0, R>::Run() [with M = mozilla::RefPtr<mozilla::AudioSessionConduit> (*)(mozilla::AudioSessionConduit*), A0 = int, R = mozilla::RefPtr<mozilla::AudioSessionConduit>, nsresult = unsigned int]’:
../../../../../../mozilla/media/webrtc/signaling/test/mediaconduit_unittests.cpp:1060:1:   instantiated from here
../../../../../../mozilla/media/mtransport/runnable_utils_generated.h:103:5: error: invalid conversion from ‘int’ to ‘mozilla::AudioSessionConduit*’
make[5]: *** [mediaconduit_unittests.o] Error 1
make[5]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/webrtc/signaling/test'
make[4]: *** [media/webrtc/signaling/test/target] Error 2
Try moving the GMP include down below the MediaConduitInterface include...  That's the change, and GMP includes that, and with unit tests often things are mocked
Attached patch proposed patch (v1) (obsolete) — Splinter Review
Attachment #8466860 - Flags: review?(rjesup)
Attachment #8466860 - Flags: review?(rjesup) → review+
Keywords: checkin-needed
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8466860 - Attachment is obsolete: true
Attachment #8466953 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a788782fc3d7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
With this hitting m-c, I'm still seeing this bustage.

Could I be missing something else?
Flags: needinfo?(rjesup)
ewong: I presumed you ran a try of CC/SeaMonkey or tested it locally...  My suggestion was that, a suggestion based on "what would GMP have changed"
Flags: needinfo?(rjesup)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
fwiw upgrading to gcc4.7.3 on beta seems to have gotten us past this error, I'll attach the patchset here within the next 12-14 hours.
Status: REOPENED → ASSIGNED
Component: WebRTC → Build Config
Product: Core → SeaMonkey
Target Milestone: mozilla34 → ---
Comment on attachment 8470653 [details] [diff] [review]
patch to fix c-r, c-a and c-c

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: need these patches in order to build.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #8470653 - Attachment description: patch to fix c-r → patch to fix c-r, c-a and c-c
Attachment #8470653 - Flags: approval-comm-release?
Attachment #8470653 - Flags: approval-comm-aurora?
I'm closing this bug in favor of bug 1047715 since it's actually the same bug.  Will move the patch there.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Comment on attachment 8470653 [details] [diff] [review]
patch to fix c-r, c-a and c-c

Cancelling requests on closed bug
Attachment #8470653 - Flags: review?(bugspam.Callek)
Attachment #8470653 - Flags: approval-comm-release?
Attachment #8470653 - Flags: approval-comm-aurora?
I'm getting:

media/mtransport/runnable_utils_generated.h:103:5: error: invalid conversion from ‘long int’ to ‘mozilla::VideoSessionConduit*’

in a Firefox 32.0 build, after upgrading from Firefox 31.0 (Linux x86_64, Fedora 14, gcc 4.5.1)
Stefan: I advise upgrading to a maintained version of Fedora (even F19 is going to EOL soon).  If you upgrade to gcc 4.7.x I believe it will work.  We don't support building Gecko with 4.5 anymore I believe.

See bug 1047715
Ok, works fine when built using gcc 4.8.
You need to log in before you can comment on or make changes to this bug.