5.7% regression in octane-crypto on MacOSX 32bit

RESOLVED FIXED in mozilla34

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: h4writer, Assigned: nbp)

Tracking

unspecified
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: awfy-fixed)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
AWFY is reporting a 5.7% regression in octane-crypto on MacOSX 32bit
http://arewefastyet.com/#machine=11&view=single&suite=octane&subtest=Crypto&start=1406547180&end=1406555257

Possibly bug 1040194?
(Reporter)

Updated

4 years ago
Blocks: 1040194
Flags: needinfo?(nicolas.b.pierron)
We can revert the patch if needed, as this is protecting us against some escape analysis cases, which is disabled by default.

I will submit a fix today.  The problem here is that we are no longer eliminating resume point operands which are completely dead in baseline, if we can recover the instruction.  Recovering an instruction is costly compared to deleting the instruction and not having to recover it at all.  This spilling overhead is what is seen here as the 5.7% regression.
Flags: needinfo?(nicolas.b.pierron)
Assignee: nobody → nicolas.b.pierron
Created attachment 8467042 [details] [diff] [review]
Remove non-observed instructions, even if they might be recovered on bailout. r=
Attachment #8467042 - Flags: review?(hv1989)
(Reporter)

Updated

4 years ago
Attachment #8467042 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/c835743934c3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.