Closed Bug 1048052 Opened 8 years ago Closed 8 years ago

'Quotes in Android DTDs need escaping with \" or \u0022' for pref_clear_on_exit_summary

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: aryx, Assigned: aryx)

References

Details

Attachments

(1 file, 1 obsolete file)

Firefox for Android Nightly and Android 2014-08-03

When running compare-locales for Fennec with the English strings, I get:

Quotes in Android DTDs need escaping with \" or \u0022

for

<!ENTITY pref_clear_on_exit_summary "&brandShortName; will automatically clear your data whenever you select &quot;Quit&quot; from the main menu">
Blocks: 1001309
Nope, should use real quotes: “”.
I thought Axel already had a note somewhere in the DTDs telling people how to handle quotes? Also, why keep double quotes? We can easily switch to single quotes, which we use \' in the DTDs.
Attached patch patch, v1 (obsolete) — Splinter Review
(In reply to Richard Newman [:rnewman] from comment #1)
> Nope, should use real quotes: “”.

Roboto and Droid Sans don't contain these glyphs:
http://www.fontsquirrel.com/fonts/roboto
http://www.fontsquirrel.com/fonts/Droid-Sans

Successful Try run: https://tbpl.mozilla.org/?tree=Try&rev=5e0b1ead5f8b&showall=1 The JIT error should be unrelated.
Attachment #8466897 - Flags: review?(mark.finkle)
(In reply to Archaeopteryx [:aryx] from comment #3)
> Roboto and Droid Sans don't contain these glyphs:
> http://www.fontsquirrel.com/fonts/roboto
> http://www.fontsquirrel.com/fonts/Droid-Sans

I see those (end of the table)
https://www.google.com/fonts/specimen/Droid+Sans
https://www.google.com/fonts/specimen/Roboto
Comment on attachment 8466897 [details] [diff] [review]
patch, v1

If \u0022 is what Pike decided we should use, from long ago, then so be it.
Attachment #8466897 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/20fe2c176690
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.