1048052 - 'Quotes in Android DTDs need escaping with \" or \u0022' for pref_clear_on_exit_summary

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android Nightly and Android 2014-08-03

When running compare-locales for Fennec with the English strings, I get:

Quotes in Android DTDs need escaping with \" or \u0022

for

<!ENTITY pref_clear_on_exit_summary "&brandShortName; will automatically clear your data whenever you select &quot;Quit&quot; from the main menu">

Comment 1

[Richard Newman [:rnewman]]

Nope, should use real quotes: “”.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I thought Axel already had a note somewhere in the DTDs telling people how to handle quotes? Also, why keep double quotes? We can easily switch to single quotes, which we use \' in the DTDs.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

(In reply to Richard Newman [:rnewman] from comment #1)
> Nope, should use real quotes: “”.

Roboto and Droid Sans don't contain these glyphs:
http://www.fontsquirrel.com/fonts/roboto
http://www.fontsquirrel.com/fonts/Droid-Sans

Successful Try run: https://tbpl.mozilla.org/?tree=Try&rev=5e0b1ead5f8b&showall=1 The JIT error should be unrelated.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Archaeopteryx [:aryx] from comment #3)
> Roboto and Droid Sans don't contain these glyphs:
> http://www.fontsquirrel.com/fonts/roboto
> http://www.fontsquirrel.com/fonts/Droid-Sans

I see those (end of the table)
https://www.google.com/fonts/specimen/Droid+Sans
https://www.google.com/fonts/specimen/Roboto

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8466897 [details] [diff] [review]
patch, v1

If \u0022 is what Pike decided we should use, from long ago, then so be it.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v2, r=mfinkle

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20fe2c176690

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20fe2c176690